From: Glauber Costa <glommer@parallels.com>
To: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org,
containers@lists.linux-foundation.org,
Pavel Emelyanov <xemul@parallels.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Hugh Dickins <hughd@google.com>, Nick Piggin <npiggin@kernel.dk>,
Andrea Arcangeli <aarcange@redhat.com>,
Rik van Riel <riel@redhat.com>,
Dave Hansen <dave@linux.vnet.ibm.com>,
James Bottomley <JBottomley@parallels.com>,
David Chinner <david@fromorbit.com>,
Glauber Costa <glommer@parallels.com>
Subject: [PATCH v2 3/4] limit nr_dentries per superblock
Date: Fri, 5 Aug 2011 04:35:43 +0400 [thread overview]
Message-ID: <1312504544-1108-4-git-send-email-glommer@parallels.com> (raw)
In-Reply-To: <1312504544-1108-1-git-send-email-glommer@parallels.com>
This patch lays the foundation for us to limit the dcache size.
Each super block can have only a maximum amount of dentries under its
sub-tree. Allocation fails if we we're over limit and the cache
can't be pruned to free up space for the newcomers.
Signed-off-by: Glauber Costa <glommer@parallels.com>
CC: Dave Chinner <david@fromorbit.com>
---
fs/dcache.c | 25 +++++++++++++++++++++++++
fs/super.c | 1 +
include/linux/fs.h | 1 +
3 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/fs/dcache.c b/fs/dcache.c
index ac19d24..52a0faf 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -1180,6 +1180,28 @@ void shrink_dcache_parent(struct dentry * parent)
}
EXPORT_SYMBOL(shrink_dcache_parent);
+static int dcache_mem_check(struct super_block *sb)
+{
+ int i;
+ int nr_dentry;
+ struct shrink_control sc = {
+ .gfp_mask = GFP_KERNEL,
+ };
+
+ do {
+ nr_dentry = 0;
+ for_each_possible_cpu(i)
+ nr_dentry += per_cpu(*sb->s_nr_dentry, i);
+
+ if (nr_dentry < sb->s_nr_dentry_max)
+ return 0;
+
+ /* nr_pages = 1, lru_pages = 0 should get delta ~ 2 */
+ } while (shrink_one_shrinker(&sb->s_shrink, &sc, 1, 0));
+
+ return -ENOMEM;
+}
+
/**
* __d_alloc - allocate a dcache entry
* @sb: filesystem it will belong to
@@ -1195,6 +1217,9 @@ struct dentry *__d_alloc(struct super_block *sb, const struct qstr *name)
struct dentry *dentry;
char *dname;
+ if (dcache_mem_check(sb))
+ return NULL;
+
dentry = kmem_cache_alloc(dentry_cache, GFP_KERNEL);
if (!dentry)
return NULL;
diff --git a/fs/super.c b/fs/super.c
index 9345385..d9bcae8 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -130,6 +130,7 @@ static struct super_block *alloc_super(struct file_system_type *type)
}
for_each_possible_cpu(i)
*per_cpu_ptr(s->s_nr_dentry, i) = 0;
+ s->s_nr_dentry_max = INT_MAX;
#ifdef CONFIG_SMP
s->s_files = alloc_percpu(struct list_head);
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 35113fd..e90dcb4 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1399,6 +1399,7 @@ struct super_block {
struct list_head s_dentry_lru; /* unused dentry lru */
int s_nr_dentry_unused; /* # of dentry on lru */
+ int s_nr_dentry_max; /* max # of dentry on this sb*/
int __percpu *s_nr_dentry; /* # of dentry on this sb */
/* s_inode_lru_lock protects s_inode_lru and s_nr_inodes_unused */
--
1.7.6
next prev parent reply other threads:[~2011-08-05 0:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 0:35 [PATCH v2 0/4] Per-container dcache size limitation Glauber Costa
2011-08-05 0:35 ` [PATCH v2 1/4] factor out single-shrinker code Glauber Costa
2011-08-05 0:35 ` [PATCH v2 2/4] Keep nr_dentry per super block Glauber Costa
2011-08-12 13:51 ` Eric Dumazet
2011-08-05 0:35 ` Glauber Costa [this message]
2011-08-12 13:56 ` [PATCH v2 3/4] limit nr_dentries per superblock Eric Dumazet
2011-08-12 19:18 ` Glauber Costa
2011-08-12 19:20 ` Glauber Costa
2011-08-05 0:35 ` [PATCH v2 4/4] parse options in the vfs level Glauber Costa
2011-08-12 10:52 ` [PATCH v2 0/4] Per-container dcache size limitation Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312504544-1108-4-git-send-email-glommer@parallels.com \
--to=glommer@parallels.com \
--cc=JBottomley@parallels.com \
--cc=aarcange@redhat.com \
--cc=containers@lists.linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=david@fromorbit.com \
--cc=hughd@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=riel@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome