mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Dmitry Artamonow <mad_soft@inbox.ru>
Cc: "lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	Ian Dobson <i.dobson@planet-ian.com>,
	Jean Delvare <khali@linux-fr.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwmon: add caseopen detection to w83627ehf driver
Date: Fri, 5 Aug 2011 09:55:50 -0700	[thread overview]
Message-ID: <1312563350.9971.123.camel@groeck-laptop> (raw)
In-Reply-To: <1312549243-7503-1-git-send-email-mad_soft@inbox.ru>

On Fri, 2011-08-05 at 09:00 -0400, Dmitry Artamonow wrote:
> Export caseopen alarm status into userspace for
> Winbond w83627* chips and also implement alarm clear knob.
> 
> Signed-off-by: Dmitry Artamonow <mad_soft@inbox.ru>

[ ... ]

> +static ssize_t
> +store_caseopen_clear(struct device *dev, struct device_attribute *attr,
> +			const char *buf, size_t count)

Another note: Please drop the "_clear" from the function name. It is
redundant with "store_". Another possible name would be
"clear_caseopen".

Thanks,
Guenter



      parent reply	other threads:[~2011-08-05 17:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-05 13:00 Dmitry Artamonow
2011-08-05 14:34 ` Guenter Roeck
2011-08-05 18:31   ` Dmitry Artamonow
2011-08-05 16:55 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312563350.9971.123.camel@groeck-laptop \
    --to=guenter.roeck@ericsson.com \
    --cc=i.dobson@planet-ian.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mad_soft@inbox.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®