From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753638Ab1HHNBO (ORCPT ); Mon, 8 Aug 2011 09:01:14 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:40652 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140Ab1HHNBM (ORCPT ); Mon, 8 Aug 2011 09:01:12 -0400 X-Authority-Analysis: v=1.1 cv=sbbt6Wn8j+VvNVI1Ftt/uHhinWyuFt+R57MN9Ty2Tys= c=1 sm=0 a=mQKKMESgVl4A:10 a=5SG0PmZfjMsA:10 a=IkcTkHD0fZMA:10 a=OPBmh+XkhLl+Enan7BmTLg==:17 a=68eEZQRoAAAA:8 a=ZfRw4ET0AAAA:8 a=tHz9FfFoAAAA:8 a=yPCof4ZbAAAA:8 a=0eTRj464pLd5CfkAHcsA:9 a=QEXdDO2ut3YA:10 a=7YLhZ6jOsBkA:10 a=KciULlu47koA:10 a=6O0IECtVFhoA:10 a=7DSvI1NPTFQA:10 a=OPBmh+XkhLl+Enan7BmTLg==:117 X-Cloudmark-Score: 0 X-Originating-IP: 67.242.120.143 Subject: Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen) From: Steven Rostedt To: Jeremy Fitzhardinge Cc: Konrad Rzeszutek Wilk , Ingo Molnar , Stephen Rothwell , xen-devel@lists.xensource.com, LKML , virtualization@lists.linux-foundation.org, Jeremy Fitzhardinge , linux-next@vger.kernel.org, "H. Peter Anvin" , Andrew Morton , Linus Torvalds , Thomas Gleixner In-Reply-To: <4E3D8657.7000704@goop.org> References: <20110725162542.39ea8d8cbd51604523635c1a@canb.auug.org.au> <20110725144629.b752bf14.rdunlap@xenotime.net> <20110804193534.GB12729@elte.hu> <20110804195539.GA11198@dumpdata.com> <20110804131516.c4da6595.rdunlap@xenotime.net> <20110804223259.GB4370@dumpdata.com> <20110804224020.GA21492@dumpdata.com> <4E3B3117.5050308@xenotime.net> <20110805080531.GA8052@elte.hu> <20110805211423.GA9765@elte.hu> <20110806015815.GA26833@dumpdata.com> <4E3D8657.7000704@goop.org> Content-Type: text/plain; charset="UTF-8" Date: Mon, 08 Aug 2011 09:01:07 -0400 Message-ID: <1312808467.18583.223.camel@gandalf.stny.rr.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2011-08-06 at 11:22 -0700, Jeremy Fitzhardinge wrote: > On 08/05/2011 06:58 PM, Konrad Rzeszutek Wilk wrote: > > On Fri, Aug 05, 2011 at 11:14:23PM +0200, Ingo Molnar wrote: > >> * Ingo Molnar wrote: > >> > >>> * Randy Dunlap wrote: > >>> > >>>> On 08/04/11 15:40, Konrad Rzeszutek Wilk wrote: > >>>>> On Thu, Aug 04, 2011 at 06:32:59PM -0400, Konrad Rzeszutek Wilk wrote: > >>>>>>>>> These build failures are still triggering upstream: > >>>>>>>>> > >>>>>>>>> arch/x86/xen/trace.c:44:2: error: array index in initializer not of integer type > >>>>>>>>> arch/x86/xen/trace.c:44:2: error: (near initialization for ‘xen_hypercall_names’) > >>>>>>>>> arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared here (not in a function) > >>>>>>>>> arch/x86/xen/trace.c:45:2: error: array index in initializer not of integer type > >>>>>>>>> arch/x86/xen/trace.c:45:2: error: (near initialization for ‘xen_hypercall_names’) > >>>>>>>> Oh, that I haven't seen. Can you send me the .config for that please. > >>>>>>> You can't be trying very hard then. I see lots of these (but no, > >>>>>> Ah, I am getting it now. Thanks for reporting it. > >>>>> This should do the trick: > >>>> Acked-by: Randy Dunlap > >>> That patch did the trick here too: > >>> > >>> Acked-by: Ingo Molnar > >> Except that i'm still seeing the occasional build failure - see the > >> error log below. Config attached. > > Much appreciate for the report. I believe this fix (which I think hit > > linux-next yesterday?) should do that: > > > > commit 1e9ea2656b656edd3c8de98675bbc0340211b5bd > > Author: Jeremy Fitzhardinge > > Date: Wed Aug 3 09:43:44 2011 -0700 > > > > xen/tracing: it looks like we wanted CONFIG_FTRACE > > > > Apparently we wanted CONFIG_FTRACE rather the CONFIG_FUNCTION_TRACER. > > > > Reported-by: Sander Eikelenboom > > Tested-by: Sander Eikelenboom > > Signed-off-by: Jeremy Fitzhardinge > > Signed-off-by: Konrad Rzeszutek Wilk > > > > diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile > > index 45e94ac..3326204 100644 > > --- a/arch/x86/xen/Makefile > > +++ b/arch/x86/xen/Makefile > > @@ -15,7 +15,7 @@ obj-y := enlighten.o setup.o multicalls.o mmu.o irq.o \ > > grant-table.o suspend.o platform-pci-unplug.o \ > > p2m.o > > > > -obj-$(CONFIG_FUNCTION_TRACER) += trace.o > > +obj-$(CONFIG_FTRACE) += trace.o > > > > I'm not sure this is correct either. Maybe it should be > CONFIG_TRACEPOINTS? Steven? Actually, I believe the correct answer is: CONFIG_EVENT_TRACING -- Steve