From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752058Ab1HIDKt (ORCPT ); Mon, 8 Aug 2011 23:10:49 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:45766 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751472Ab1HIDKs (ORCPT ); Mon, 8 Aug 2011 23:10:48 -0400 Subject: Re: [PATCH] slub: fix check_bytes() for slub debugging From: Eric Dumazet To: Akinobu Mita Cc: linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , Matt Mackall , linux-mm@kvack.org In-Reply-To: <1312709438-7608-1-git-send-email-akinobu.mita@gmail.com> References: <1312709438-7608-1-git-send-email-akinobu.mita@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 09 Aug 2011 05:10:40 +0200 Message-ID: <1312859440.2531.20.camel@edumazet-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le dimanche 07 août 2011 à 18:30 +0900, Akinobu Mita a écrit : > The check_bytes() function is used by slub debugging. It returns a pointer > to the first unmatching byte for a character in the given memory area. > > If the character for matching byte is greater than 0x80, check_bytes() > doesn't work. Becuase 64-bit pattern is generated as below. > > value64 = value | value << 8 | value << 16 | value << 24; > value64 = value64 | value64 << 32; > > The integer promotions are performed and sign-extended as the type of value > is u8. The upper 32 bits of value64 is 0xffffffff in the first line, and > the second line has no effect. > > This fixes the 64-bit pattern generation. > > Signed-off-by: Akinobu Mita > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: Matt Mackall > Cc: linux-mm@kvack.org > --- > mm/slub.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index eb5a8f9..5695f92 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -701,7 +701,7 @@ static u8 *check_bytes(u8 *start, u8 value, unsigned int bytes) > return check_bytes8(start, value, bytes); > > value64 = value | value << 8 | value << 16 | value << 24; > - value64 = value64 | value64 << 32; > + value64 = (value64 & 0xffffffff) | value64 << 32; > prefix = 8 - ((unsigned long)start) % 8; > > if (prefix) { Still buggy I am afraid. Could we use the following ? value64 = value; value64 |= value64 << 8; value64 |= value64 << 16; value64 |= value64 << 32;