From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753162Ab1HITmp (ORCPT ); Tue, 9 Aug 2011 15:42:45 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:37665 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780Ab1HITjP (ORCPT ); Tue, 9 Aug 2011 15:39:15 -0400 From: To: , CC: , Vijay Badawadagi , Pavan Savoy Subject: [PATCH 4/8] drivers:misc: ti-st: fail-safe on wrong pkt type Date: Tue, 9 Aug 2011 14:38:56 -0500 Message-ID: <1312918749-29627-5-git-send-email-pavan_savoy@ti.com> X-Mailer: git-send-email 1.5.6.3 In-Reply-To: <1312918749-29627-4-git-send-email-pavan_savoy@ti.com> References: <1312918749-29627-1-git-send-email-pavan_savoy@ti.com> <1312918749-29627-2-git-send-email-pavan_savoy@ti.com> <1312918749-29627-3-git-send-email-pavan_savoy@ti.com> <1312918749-29627-4-git-send-email-pavan_savoy@ti.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vijay Badawadagi Texas Instrument's shared transport driver interpret incoming data from the UART based on the various protocol drivers registered to the driver such as btwilink driver or FM or GPS driver which provide logical channel IDs. In case of bad-behavior from chip such as HCI Event response for a GPS command or a HCI Event (h/w error event) for a FM response & In case of bad-behavior from UART driver such as dropping data bytes a fail-safe is required to avoid kernel panic. Change-Id: I4a0b4b3152a27830ae85f986f5f2de922f007cd2 Signed-off-by: Pavan Savoy Signed-off-by: Vijay Badawadagi --- drivers/misc/ti-st/st_core.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c index c8e335d..1f973ce 100644 --- a/drivers/misc/ti-st/st_core.c +++ b/drivers/misc/ti-st/st_core.c @@ -338,6 +338,12 @@ void st_int_recv(void *disc_data, /* Unknow packet? */ default: type = *ptr; + if (st_gdata->list[type] == NULL) { + pr_err("chip/interface misbehavior dropping" + " frame starting with 0x%02x", type); + goto done; + + } st_gdata->rx_skb = alloc_skb( st_gdata->list[type]->max_frame_size, GFP_ATOMIC); @@ -354,6 +360,7 @@ void st_int_recv(void *disc_data, ptr++; count--; } +done: spin_unlock_irqrestore(&st_gdata->lock, flags); pr_debug("done %s", __func__); return; -- 1.7.4.1