From: <pavan_savoy@ti.com>
To: <gregkh@suse.de>, <linux-kernel@vger.kernel.org>
Cc: <pavan_savoy@sify.com>, Pavan Savoy <pavan_savoy@ti.com>
Subject: [PATCH 6/8] drivers:misc: ti-st: wait for completion at fail
Date: Tue, 9 Aug 2011 14:38:58 -0500 [thread overview]
Message-ID: <1312918749-29627-7-git-send-email-pavan_savoy@ti.com> (raw)
In-Reply-To: <1312918749-29627-6-git-send-email-pavan_savoy@ti.com>
From: Pavan Savoy <pavan_savoy@ti.com>
When the line discipline install fails for reasons such as missing user-space
UIM or broken communication between UIM and ST driver, then the ST
attempts/retries to request for ldisc installation again.
based out of: OMAPS00246156
Change-Id: Ib1cd03ebd078bbbc2d93b68a37ba2ce1e7fa497e
Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
---
drivers/misc/ti-st/st_kim.c | 13 +++++++++++++
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c
index 1748a93..d8ca406 100644
--- a/drivers/misc/ti-st/st_kim.c
+++ b/drivers/misc/ti-st/st_kim.c
@@ -473,6 +473,12 @@ long st_kim_start(void *kim_data)
pr_info("ldisc_install = 0");
sysfs_notify(&kim_gdata->kim_pdev->dev.kobj,
NULL, "install");
+ /* the following wait is never going to be completed,
+ * since the ldisc was never installed, hence serving
+ * as a mdelay of LDISC_TIME msecs */
+ err = wait_for_completion_timeout
+ (&kim_gdata->ldisc_installed,
+ msecs_to_jiffies(LDISC_TIME));
err = -ETIMEDOUT;
continue;
} else {
@@ -485,6 +491,13 @@ long st_kim_start(void *kim_data)
pr_info("ldisc_install = 0");
sysfs_notify(&kim_gdata->kim_pdev->dev.kobj,
NULL, "install");
+ /* this wait might be completed, though in the
+ * tty_close() since the ldisc is already
+ * installed */
+ err = wait_for_completion_timeout
+ (&kim_gdata->ldisc_installed,
+ msecs_to_jiffies(LDISC_TIME));
+ err = -EINVAL;
continue;
} else { /* on success don't retry */
break;
--
1.7.4.1
next prev parent reply other threads:[~2011-08-09 19:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 19:38 [PATCH 0/8] drivers:misc: ti-st: fixes pavan_savoy
2011-08-09 19:38 ` [PATCH 1/8] drivers:misc: ti-st: avoid a misleading dbg msg pavan_savoy
2011-08-09 19:38 ` [PATCH 2/8] drivers:misc:ti-st: platform hooks for chip states pavan_savoy
2011-08-09 19:38 ` [PATCH 3/8] drivers:misc: ti-st: reinit completion on ver read pavan_savoy
2011-08-09 19:38 ` [PATCH 4/8] drivers:misc: ti-st: fail-safe on wrong pkt type pavan_savoy
2011-08-09 19:38 ` [PATCH 5/8] drivers:misc: ti-st: reinit completion before send pavan_savoy
2011-08-09 19:38 ` pavan_savoy [this message]
2011-08-09 19:38 ` [PATCH 7/8] drivers:misc: ti-st: free skb on firmware download pavan_savoy
2011-08-09 19:39 ` [PATCH 8/8] drivers:misc: ti-st: fix unexpected UART close pavan_savoy
2011-08-09 19:39 ` [PATCH 0/8] drivers:misc: ti-st: fixes pavan_savoy
2011-08-09 19:39 ` [PATCH 1/8] drivers:misc: ti-st: avoid a misleading dbg msg pavan_savoy
2011-08-09 19:39 ` [PATCH 2/8] drivers:misc:ti-st: platform hooks for chip states pavan_savoy
2011-08-09 19:39 ` [PATCH 3/8] drivers:misc: ti-st: reinit completion on ver read pavan_savoy
2011-08-09 19:39 ` [PATCH 4/8] drivers:misc: ti-st: fail-safe on wrong pkt type pavan_savoy
2011-08-09 19:39 ` [PATCH 5/8] drivers:misc: ti-st: reinit completion before send pavan_savoy
2011-08-09 19:39 ` [PATCH 6/8] drivers:misc: ti-st: wait for completion at fail pavan_savoy
2011-08-09 19:39 ` [PATCH 7/8] drivers:misc: ti-st: free skb on firmware download pavan_savoy
2011-08-09 19:39 ` [PATCH 8/8] drivers:misc: ti-st: fix unexpected UART close pavan_savoy
2011-08-09 20:30 ` [PATCH 1/8] drivers:misc: ti-st: avoid a misleading dbg msg Greg KH
2011-08-09 20:31 ` [PATCH 0/8] drivers:misc: ti-st: fixes Greg KH
2011-08-10 2:54 ` Pavan Savoy
2011-08-10 15:18 pavan_savoy
2011-08-10 15:18 ` [PATCH 1/8] drivers:misc: ti-st: avoid a misleading dbg msg pavan_savoy
2011-08-10 15:18 ` [PATCH 2/8] drivers:misc:ti-st: platform hooks for chip states pavan_savoy
2011-08-10 15:18 ` [PATCH 3/8] drivers:misc: ti-st: reinit completion on ver read pavan_savoy
2011-08-10 15:18 ` [PATCH 4/8] drivers:misc: ti-st: fail-safe on wrong pkt type pavan_savoy
2011-08-10 15:18 ` [PATCH 5/8] drivers:misc: ti-st: reinit completion before send pavan_savoy
2011-08-10 15:18 ` [PATCH 6/8] drivers:misc: ti-st: wait for completion at fail pavan_savoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312918749-29627-7-git-send-email-pavan_savoy@ti.com \
--to=pavan_savoy@ti.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavan_savoy@sify.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®