mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Pekka Enberg <penberg@kernel.org>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Andi Kleen <ak@linux.intel.com>, Ingo Molnar <mingo@elte.hu>,
	Brian Gerst <brgerst@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	"x86@kernel.org" <x86@kernel.org>,
	LinusTorvalds <torvalds@linux-foundation.org>
Subject: [PATCH 0/2 v2] minor cleanups to EFLAGS initialisation in ret_from_fork
Date: Wed, 10 Aug 2011 17:29:03 +0100	[thread overview]
Message-ID: <1312993743.26263.268.camel@zakaz.uk.xensource.com> (raw)

The following series removes the use of a global kernel_eflags variable
from the x86_64 ret_from_fork path and (very slightly) merges the 32 and
64 bit version of that code path.

kernel_eflags could be made a __read_mostly but actually there is no
reason to prefer the value at cpu_init() time to a compile time constant
value for the initial eflags after a fork.

Test booted on 32 and 64 bit.

changes since v1:
      * rebased onto tip/master
      * make 32 bit look like 64 bit instead of vice versa since the
        behaviour of resetting eflags with interrupts disabled before
        calling schedule_tail seems more obviously safe than resetting
        eflags with interrupts enabled afterwards (although I think both
        are actually correct).
      * As a consequence of the above patch 3/3 (use symbolic names for
        bits in eflags) goes away since we only use the MBO bit 1 now,
        which doesn't have a name.


             reply	other threads:[~2011-08-10 16:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10 16:29 Ian Campbell [this message]
2011-08-10 16:29 ` [PATCH 1/2] x86: drop unnecessary kernel_eflags variable from 64 bit Ian Campbell
2011-08-10 16:29 ` [PATCH 2/2] x86: make 32 bit ret_from_fork a little more similar to " Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312993743.26263.268.camel@zakaz.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=ak@linux.intel.com \
    --cc=brgerst@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®