From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8959126F29B for ; Wed, 11 Feb 2026 01:08:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770772110; cv=none; b=MYP7cIOaUIlpUIYYW2us7lM2mGNTq5yCLgVoRkdXld50bZk/WCN0u/1rbgaWmCRINwqxvWV/7icTY2sYj81/2QN2Xgm4rPMsyCbq+g7paKWBOLeE7RBzK/KONdKm27JEnMcqmvqTno6KXJ68pz9tqKKA6zD97te7p9AeM0skLvE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770772110; c=relaxed/simple; bh=GyTr5A2j9IIqqKvUDAgCa+1wQmdDWS20FZz1ktFv6bc=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=OWEZ+ysnWq+93UwMfMAPOZRmTMUiyLHIMGVQ8/32IpMF6yeFJ7thbYVnGZtzr5IqBA4u8ZfLGsX74jZPxbQ5sV6EI9qP2VZIGcicjfOTNj+nvgcPqxJYP1T9cfGN9tcP5Twv56Atb0BbINKd3DdP9TzWVJnvT1288Jf9VrtM0Xg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YUQn/DBf; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YUQn/DBf" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-352ccc61658so2985649a91.0 for ; Tue, 10 Feb 2026 17:08:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770772109; x=1771376909; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=MfwWp2t/9khjgvGcWC9Uv1y2hbwrcLMsb6xETQEevAM=; b=YUQn/DBfy+CWjNUtUKLeYw/CqmjWrxN+jxw8r8RX4UlS2U2fU+yZCQ49OcxfTtqsRn YajBQ9rYxioxk4aUvcYN1oPu/CIcEOlBtmEYA8YO3kBA3eTl6RKX9Po8yYxfESIZXejp ky4RoKTU2iPYbZjlGjqwNbbWDoiek95MUjh2E4dvd6fkTAFnroK343qMkbQr3swsIQJa Mznm9/ZmL7W0CQnBhQML2Jv2sUCjOl/jtGdrBAT9+CFlhMyHTuD4msQd5eCohk+mqDM9 O96glwLgFJ/u92UiJHP+ju/WDauMg4XnM0E3MtDQARCj2oNp2sBn0Qvp+/1Xxl6aFa9n aktg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770772109; x=1771376909; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MfwWp2t/9khjgvGcWC9Uv1y2hbwrcLMsb6xETQEevAM=; b=C7Wv9T2ZdY1LjnJLTQ7gVNKuexabll8HgvlXZ4wX0vPmYvyu3bjh1cLb+1lMLBs+A7 9v4TXgG3J/6LeuHSfrAeFhRRgC3v5PdyLfnwXs24zHgjwD7jDmKX0+JWibD6sp0nTbQ6 8tEJyefg/YwkhLoeuvTIf9RP5NSYSKv2hr9y9RwwYZJwOKwm0jb3uYrx9tE0M5jr9Hdl ye58dE9RGguy8lvjtJrPiF2Z36f12zO243EH6e8BkQKNia4FmUWV3jOvY0IlHAjtyKF3 kr0Idm/+I5x5orPOWWURNRaw8kVxd7BsXPmxrRiro0GQglpSJoVCZ+5w1fg9Odj4Y5bY B+iw== X-Forwarded-Encrypted: i=1; AJvYcCVo1SnNKzlq2FD/BCYByl8GBnQhJn1vWpSVZQgJdRYwEgF66mkelvtZls/PQ77Y98fuj1fe3D6EukSd1lk=@vger.kernel.org X-Gm-Message-State: AOJu0YwWkP9MigIvWnGM2oVjUhujUyZz7dnkfzi1w7/2Vh49GdxIRK50 975gNk/DoFdZAdn65aqRXZfj0kD38BJYUJ3aiGbA8ndA8GH/1nrBcPRh X-Gm-Gg: AZuq6aK/NKQKs26n/xuluLCKfEdHWBckAlPBSYuYRkJSps4j5iLQrYCEN4Kloca+yu4 p43HXNe/kxndV4BrnaGqPkWOR5VAsMFll5LZriNXI9Q83cQTAKj5+KF/RIuvasPqFL8xbFTNJaP cyIuUWGU9TTgOiiB78V6sZVm0IjAW/lLjMea4s24EA7uIYnKYiV9/gxkvtp3vAM5NbSC/1Zq800 PTkvfTym8QY3EClH2kIlE/Nt8ZgJG/pB56E4UcJT0xtVhm1cmfP1iMI1XzE7iFEn9iaX6SgQojH CdkrNdPRNdrdwLRmVJxr1ZF/Vesm8d0ehNxd0qrOw4dVyaAAj1aIKDU3Bd/Rq9BL7EmNt6FbEr0 FXQ4SH5uCWni6mPCKKvf1Da6zPjXpkcbwQDCxWIpj8/vEAcn7FD6oYINIdVyQTwEu6jTkWPvyl9 4+RLVgBj81uxyJkkcmB2BTZd/+xdM/DtZtOpNSv1POy7+sUCeTFRMVEwY= X-Received: by 2002:a17:903:1108:b0:2a7:9948:45a4 with SMTP id d9443c01a7336-2ab29ce581cmr5116145ad.25.1770772108812; Tue, 10 Feb 2026 17:08:28 -0800 (PST) Received: from [192.168.116.129] ([49.205.41.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ab29964c62sm3074225ad.55.2026.02.10.17.08.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 17:08:28 -0800 (PST) Message-ID: <1312bba9-442b-410a-9cb4-fe67879d2dcb@gmail.com> Date: Wed, 11 Feb 2026 06:38:24 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/4] rust: alloc: add Vec shrinking methods To: Danilo Krummrich , Alice Ryhl , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260207-binder-shrink-vec-v3-v3-0-8ff388563427@cock.li> <0d336a3f-f317-4a70-942a-d87a3faa3a89@gmail.com> Content-Language: en-US From: Shivam Kalra In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/02/26 02:41, Danilo Krummrich wrote: > On Tue Feb 10, 2026 at 9:58 PM CET, Alice Ryhl wrote: >> On Tue, Feb 10, 2026 at 9:54 PM Danilo Krummrich wrote: >> Yes that's what I meant. Only provide shrink_to() for those. After >> all, if Kmalloc never actually shrinks when you call realloc, what's >> the point of having KVec::shrink_to()? > > Nothing, but eventually we want a generic impl of shrink_to() with A::realloc(). > But again, for now that's fine. Thanks for the discussion. Just want to confirm my understanding of the agreed approach: Since VVec and KVVec are type aliases for Vec and Vec, implementing shrink_to() on "only VVec and KVVec" means writing separate impl blocks: impl Vec { fn shrink_to() { ... } } impl Vec { fn shrink_to() { ... } } Is that what you had in mind, with the shrink logic duplicated in both? Or would you prefer a shared impl with a trait bound to avoid duplication?