From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754692Ab1HJSwI (ORCPT ); Wed, 10 Aug 2011 14:52:08 -0400 Received: from casper.infradead.org ([85.118.1.10]:35756 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753878Ab1HJSwH (ORCPT ); Wed, 10 Aug 2011 14:52:07 -0400 Subject: Re: [PATCH 2/2] Enable 'make CONFIG_FOO=y oldconfig' From: David Woodhouse To: Arnaud Lacombe Cc: Michal Marek , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org Date: Wed, 10 Aug 2011 19:52:01 +0100 In-Reply-To: References: <1312067499.22074.59.camel@i7.infradead.org> <1312067670.22074.61.camel@i7.infradead.org> <4E34998D.8060806@zytor.com> <4E4140B3.7090802@suse.cz> <4E4280BA.9050109@suse.cz> <1312981658.2989.39.camel@i7.infradead.org> <1312985888.2989.46.camel@i7.infradead.org> <1312993987.2989.53.camel@i7.infradead.org> <1312999168.2989.61.camel@i7.infradead.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.0.2 (3.0.2-3.fc15) Content-Transfer-Encoding: 7bit Message-ID: <1313002322.2989.88.camel@i7.infradead.org> Mime-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2011-08-10 at 14:40 -0400, Arnaud Lacombe wrote: > so, at best, this buggy behavior is ~ 6 years old. Before that, I'd > assume that the internal namespace was not accessible by any other > mean than the front-ends. I've been editing .config or doing 's/.*CONFIG_FOO[= ].*/CONFIG_FOO=y/' on it for a decade before that. With all the same limitations as all.config, and my new CONFIG_FOO=y command line support. How do *you* quickly, from the command line, enable or disable a single option in an existing config? > > Please, if this offends you then by all means go and fix it. A sane way > > of handling dependencies would give a way to say "do what you need to do > > in order to enable CONFIG_SATA_MV", and should remove the abomination of > > 'select', which was introduced purely to work around that lack. > > > > But none of that is directly relevant in *this* thread. > > > to paraphrase you, I'd say, this might looks "cute but might give > behavior that people will come to depend on in their scripts and then > we take it away again", "that's why I'd kind of like to see it done > *once*, *properly*". That's a reasonable concern, but I think it's misplaced in this case. We're not enabling anything that we're later going to break. I can't see many people *depending* on the fact that 'make CONFIG_SATA_MV=y oldconfig' actually does *nothing* in some cases. When we later, hopefully, get proper dependency resolution, that will take something that *wasn't* working and make it work. For all.config and for the command line overrides (and in other places) at the same time. -- dwmw2