From: Ravishankar <ravishankarkm32@gmail.com>
To: gregkh@suse.de, wfp5p@virginia.edu
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Ravishankar <ravi.shankar@greenturtles.in>,
Ravishankar <ravishankarkm32@gmail.com>
Subject: [PATCH] Staging: comedi: fix printk() issue in das1800.c
Date: Thu, 11 Aug 2011 12:27:44 +0530 [thread overview]
Message-ID: <1313045864-20313-1-git-send-email-ravishankarkm32@gmail.com> (raw)
In-Reply-To: <[PATCH]Staging: comedi: fix printk warning issue in das1800.c>
From: Ravishankar <ravi.shankar@greenturtles.in>
This is a patch to the das1800.c file that fixes up a printk() warning found by the checkpatch.pl tool
Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
---
drivers/staging/comedi/drivers/das1800.c | 49 +++++++++++++----------------
1 files changed, 22 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c
index a6df30b..ee5f614 100644
--- a/drivers/staging/comedi/drivers/das1800.c
+++ b/drivers/staging/comedi/drivers/das1800.c
@@ -826,76 +826,71 @@ static int das1800_probe(struct comedi_device *dev)
int id;
int board;
- id = (inb(dev->iobase + DAS1800_DIGITAL) >> 4) & 0xf; /* get id bits */
+ /* get id bits */
+ id = (inb(dev->iobase + DAS1800_DIGITAL) >> 4) & 0xf;
board = ((struct das1800_board *)dev->board_ptr) - das1800_boards;
switch (id) {
case 0x3:
if (board == das1801st_da || board == das1802st_da ||
board == das1701st_da || board == das1702st_da) {
- printk(" Board model: %s\n",
- das1800_boards[board].name);
+ printk(KERN_DEBUG " Board model: %s\n",
+ das1800_boards[board].name);
return board;
}
- printk
- (" Board model (probed, not recommended): das-1800st-da series\n");
+ printk(KERN_DEBUG " Board model (probed, not recommended): das-1800st-da series\n");
return das1801st;
break;
case 0x4:
if (board == das1802hr_da || board == das1702hr_da) {
- printk(" Board model: %s\n",
- das1800_boards[board].name);
+ printk(KERN_DEBUG " Board model: %s\n",
+ das1800_boards[board].name);
return board;
}
- printk
- (" Board model (probed, not recommended): das-1802hr-da\n");
+ printk(KERN_DEBUG " Board model (probed, not recommended): das-1802hr-da\n");
return das1802hr;
break;
case 0x5:
if (board == das1801ao || board == das1802ao ||
board == das1701ao || board == das1702ao) {
- printk(" Board model: %s\n",
- das1800_boards[board].name);
+ printk(KERN_DEBUG " Board model: %s\n",
+ das1800_boards[board].name);
return board;
}
- printk
- (" Board model (probed, not recommended): das-1800ao series\n");
+ printk(KERN_DEBUG " Board model (probed, not recommended): das-1800ao series\n");
return das1801ao;
break;
case 0x6:
if (board == das1802hr || board == das1702hr) {
- printk(" Board model: %s\n",
- das1800_boards[board].name);
+ printk(KERN_DEBUG " Board model: %s\n",
+ das1800_boards[board].name);
return board;
}
- printk(" Board model (probed, not recommended): das-1802hr\n");
+ printk(KERN_DEBUG " Board model (probed, not recommended): das-1802hr\n");
return das1802hr;
break;
case 0x7:
if (board == das1801st || board == das1802st ||
board == das1701st || board == das1702st) {
- printk(" Board model: %s\n",
- das1800_boards[board].name);
+ printk(KERN_DEBUG " Board model: %s\n",
+ das1800_boards[board].name);
return board;
}
- printk
- (" Board model (probed, not recommended): das-1800st series\n");
+ printk(KERN_DEBUG " Board model (probed, not recommended): das-1800st series\n");
return das1801st;
break;
case 0x8:
if (board == das1801hc || board == das1802hc) {
- printk(" Board model: %s\n",
- das1800_boards[board].name);
+ printk(KERN_DEBUG " Board model: %s\n",
+ das1800_boards[board].name);
return board;
}
- printk
- (" Board model (probed, not recommended): das-1800hc series\n");
+ printk(KERN_DEBUG " Board model (probed, not recommended): das-1800hc series\n");
return das1801hc;
break;
default:
- printk
- (" Board model: probe returned 0x%x (unknown, please report)\n",
- id);
+ printk(KERN_DEBUG " Board model: probe returned 0x%x (unknown, please report)\n",
+ id);
return board;
break;
}
--
1.6.5.2
parent reply other threads:[~2011-08-11 6:43 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <[PATCH]Staging: comedi: fix printk warning issue in das1800.c>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313045864-20313-1-git-send-email-ravishankarkm32@gmail.com \
--to=ravishankarkm32@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.shankar@greenturtles.in \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®