mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
	Dick Streefland <dick@streefland.net>,
	WANG Cong <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH] scripts: add extract-vmlinux
Date: Thu, 11 Aug 2011 13:28:21 +0200	[thread overview]
Message-ID: <1313062101.8300.23.camel@x61.thuisdomein> (raw)
In-Reply-To: <1313052783-27607-1-git-send-email-corentin.chary@gmail.com>

On Thu, 2011-08-11 at 10:53 +0200, Corentin Chary wrote:
> This script can be used to extract vmlinux from a compressed
> kernel image (bzImage, etc..). It's inspired from (a subset of)
> extract-ikconfig.

This is more specific than what this scripts actually does, isn't it? At
least when I tried to read this script my impression is that it does two
things:
- check whether the input file is a valid ELF file;
- if not; try to find a compressed ELF file somewhere in the input file.

There's no checking whether the input file is a kernel image and there's
no checking whether the found ELF file actually is was a, well, vmlinux.
Both checks are perhaps far from trivial. Anyhow, if that's correct this
should be made more clear. Perhaps the script should even be called
something like extract-elf.

> It's something a lot of people have been looking for (mainly
> people with xen < 4 that doesn't support bzImages at all).
> 
> Signed-off-by: Corentin Chary <corentin.chary@gmail.com>
> [...]
> +try_decompress()
> +{
> +	for	pos in `tr "$1\n$2" "\n$2=" < "$img" | grep -abo "^$2"`
> +	do
> +		pos=${pos%%:*}
> +		tail -c+$pos "$img" | $3 > $tmp 2> /dev/null

Perhaps a few comments on the above lines would be nice. Without those
comments I must guess you're finding compressed data somewhere in the
input file. It also seems you're looping through the entire input file.
Or are (sequences of) commands like the above considered obvious?

> +		check_elf $tmp
> +	done
> +}
> +
> [...]
> +# Initial attempt for uncompressed images or objects:
> +check_elf $img
> +
> +# That didn't work, so retry after decompression.
> +try_decompress '\037\213\010' xy    gunzip
> +try_decompress '\3757zXZ\000' abcde unxz
> +try_decompress 'BZh'          xy    bunzip2
> +try_decompress '\135\0\0\0'   xxx   unlzma
> +try_decompress '\211\114\132' xy    'lzop -d'

Perhaps you could first test whether these commands are available before
running try_decompress() with them?


Paul Bolle


  reply	other threads:[~2011-08-11 11:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-04 13:52 Corentin Chary
2011-08-10 13:27 ` Michal Marek
2011-08-11  7:21   ` Corentin Chary
2011-08-11  7:53     ` Dick Streefland
2011-08-11  8:42     ` Américo Wang
2011-08-11  8:53 ` Corentin Chary
2011-08-11 11:28   ` Paul Bolle [this message]
2011-08-11 13:08     ` Corentin Chary
2011-08-11 13:33       ` Michal Marek
2011-08-11 14:23         ` Corentin Chary
2011-08-11 15:47           ` Corentin Chary
2011-08-16  8:46 ` [PATCH v3] " Corentin Chary
2011-08-18 10:09   ` Américo Wang
2011-08-26  9:49     ` Corentin Chary
2011-08-19  6:51   ` Ian Campbell
2011-08-19  7:52     ` Corentin Chary
2011-08-31 14:16   ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313062101.8300.23.camel@x61.thuisdomein \
    --to=pebolle@tiscali.nl \
    --cc=corentin.chary@gmail.com \
    --cc=dick@streefland.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®