From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755931Ab1HKNUz (ORCPT <rfc822;w@1wt.eu>);
	Thu, 11 Aug 2011 09:20:55 -0400
Received: from casper.infradead.org ([85.118.1.10]:48954 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755578Ab1HKNUw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 11 Aug 2011 09:20:52 -0400
Subject: Re: [PATCH 2/2] Enable 'make CONFIG_FOO=y oldconfig'
From: David Woodhouse <dwmw2@infradead.org>
To: Michal Marek <mmarek@suse.cz>
Cc: Andreas Schwab <schwab@redhat.com>, Arnaud Lacombe <lacombar@gmail.com>,
        "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org,
        linux-kbuild@vger.kernel.org
Date: Thu, 11 Aug 2011 14:20:41 +0100
In-Reply-To: <4E43C363.3000103@suse.cz>
References: <1312067499.22074.59.camel@i7.infradead.org>
	  <4E4280BA.9050109@suse.cz> <1312981658.2989.39.camel@i7.infradead.org>
	  <CACqU3MUJkM3Y2o2Jx1eQxZkW2T-Dby1JCaks6SqTz_FB17hSvw@mail.gmail.com>
	  <1312985888.2989.46.camel@i7.infradead.org>
	  <CACqU3MXozgu0kr-4w=bGejcEi8MrxH-PhKa0Ji0zrLu7ZEFomg@mail.gmail.com>
	  <1312993987.2989.53.camel@i7.infradead.org>
	  <CACqU3MXC_eDqgWDwnVe8KsqoAMTPQNiP6YMHD5G+1sMBhMwXzA@mail.gmail.com>
	  <1312999168.2989.61.camel@i7.infradead.org>
	  <CACqU3MWB+4n5Acd-GboH5WbCzfZFiAc0wNvOkn_5O+--7jLE8A@mail.gmail.com>
	  <1313002322.2989.88.camel@i7.infradead.org>
	  <CACqU3MU2J25q-wWJ8LNcMkwi3uMigz_+0=XcrNiPC0TGiJHZqA@mail.gmail.com>
	  <1313018232.2989.114.camel@i7.infradead.org>
	  <CACqU3MVyjzr47N9v23SGaSjiEOGoEaP1-TZ4Z_RyVNgVXgPEwg@mail.gmail.com>
	  <1313052168.18037.9.camel@i7.infradead.org> <4E4399B3.3020909@suse.cz>
	  <1313061012.18037.17.camel@i7.infradead.org> <m3r54std0x.fsf@hase.home>
	 <1313062813.18037.24.camel@i7.infradead.org> <4E43C363.3000103@suse.cz>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.0.2 (3.0.2-3.fc15) 
Content-Transfer-Encoding: 7bit
Message-ID: <1313068845.18037.29.camel@i7.infradead.org>
Mime-Version: 1.0
X-SRS-Rewrite: SMTP reverse-path rewritten from <dwmw2@infradead.org> by casper.infradead.org
	See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2011-08-11 at 13:56 +0200, Michal Marek wrote:
> 
> If you do
> $ echo 'CONFIG_FOO=y' >all.config
> $ make allnoconfig bzImage
> then it will also build bzImage even if kconfig wasn't able to set
> CONFIG_FOO=y. IMO printing a warning that CONFIG_FOO could not be set is
> sufficient, as long as CONFIG_FOO is consistently unset. 

The thing is, such a warning is likely to be lost in the scrollback.

There's definitely something to be said for:

[dwmw2@i7 linux-2.6]$ make CONFIG_SATA_MV=y bzImage
Makefile:572: *** CONFIG_SATA_MV could not be set to "y" as requested.  Stop.

-- 
dwmw2