mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Geunsik Lim <leemgs1@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] ftrace: tracing_on to start/stop tracing
Date: Fri, 12 Aug 2011 13:06:28 -0400	[thread overview]
Message-ID: <1313168788.18583.342.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1313127022-23830-1-git-send-email-leemgs1@gmail.com>

On Fri, 2011-08-12 at 14:30 +0900, Geunsik Lim wrote:
> From: Geunsik Lim <geunsik.lim@samsung.com>
> 
> tracing_enabled option is deprecated.
> To start/stop tracing, write to /sys/kernel/debug/tracing/tracing_on
> without tracing_enabled. This patch is based on Linux 3.1.0-rc1
> 

Ug, I thought I fixed this. OK, thanks. Maybe we can add this to 3.1, as
it is a very low risk patch and fixes something that can confuse people.

-- Steve

> Signed-off-by: Geunsik Lim <geunsik.lim@samsung.com>
> ---
>  kernel/trace/trace.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index e5df02c..91abdbf 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -2710,9 +2710,9 @@ static const char readme_msg[] =
>  	"# cat /sys/kernel/debug/tracing/trace_options\n"
>  	"noprint-parent nosym-offset nosym-addr noverbose\n"
>  	"# echo print-parent > /sys/kernel/debug/tracing/trace_options\n"
> -	"# echo 1 > /sys/kernel/debug/tracing/tracing_enabled\n"
> +	"# echo 1 > /sys/kernel/debug/tracing/tracing_on\n"
>  	"# cat /sys/kernel/debug/tracing/trace > /tmp/trace.txt\n"
> -	"# echo 0 > /sys/kernel/debug/tracing/tracing_enabled\n"
> +	"# echo 0 > /sys/kernel/debug/tracing/tracing_on\n"
>  ;
>  
>  static ssize_t



      reply	other threads:[~2011-08-12 17:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-12  5:30 Geunsik Lim
2011-08-12 17:06 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313168788.18583.342.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=leemgs1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®