From: Matt Fleming <matt@console-pimps.org>
To: "Håvard Skinnemoen" <hskinnemoen@gmail.com>
Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>,
linux-kernel <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: avr32: handle_signal() bug?
Date: Tue, 16 Aug 2011 10:57:28 +0100 [thread overview]
Message-ID: <1313488648.3436.126.camel@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <CAF8ieYV_3skMFo4Mc59hX1g1tFEjg8Fjnag36ZQwU9w=CPkLLQ@mail.gmail.com>
On Mon, 2011-08-15 at 22:55 -0700, Håvard Skinnemoen wrote:
> Hi,
>
> Sorry for taking so long to test this.
No worries!
> On Mon, Aug 8, 2011 at 3:25 AM, Matt Fleming <matt@console-pimps.org> wrote:
> > On Sun, 2011-08-07 at 10:20 -0700, Håvard Skinnemoen wrote:
> >> Looks good to me. I'm not sure how to test it though...I can try to
> >> build a kernel, run it on my board and see if it explodes, but I
> >> suspect this bug is a lot more subtle than that.
> >
> > I suspect the best test would be one that makes use of SA_NODEFER.
> > Something like this,
>
> Thanks for the test. Unfortunately, the result is the same regardless
> of whether I apply the patches or not. In both cases:
>
> /root # ./nodefer
> SIGUSR2: not blocked
> SIGTERM: not blocked
Hmm.. that's interesting. I had a quick look through the rest of the
code in the signal path and couldn't find anything obviously wrong. The
only thing that looked suspicious is that you don't clear
TIF_RESTORE_SIGMASK if you successsfully deliver a signal. Maybe try
adding a clear_thread_flag(TIF_RESTORE_SIGMASK); to the success path in
handle_signal() and see if you get better results? See the x86
implementation for more details.
> On my desktop, it behaves as expected:
>
> $ ./nodefer-pc
> SIGUSR2: blocked
> SIGTERM: blocked
>
> Your patch doesn't appear to do any harm though, and it looks correct
> to me. Perhaps there's another bug lurking somewhere as well. Some
> preliminary debugging makes me suspicious about libc, but I can't tell
> for sure yet.
Which libc is this by the way?
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-08-16 9:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 9:04 Matt Fleming
2011-08-03 13:08 ` Oleg Nesterov
2011-08-03 13:39 ` [PATCH] avr32: use set_current_blocked() in handle_signal/sys_rt_sigreturn Oleg Nesterov
2011-08-03 13:56 ` Matt Fleming
2011-08-07 17:20 ` avr32: handle_signal() bug? Håvard Skinnemoen
2011-08-08 10:25 ` Matt Fleming
2011-08-16 5:55 ` Håvard Skinnemoen
2011-08-16 9:57 ` Matt Fleming [this message]
2011-08-16 15:39 ` Oleg Nesterov
2011-08-17 5:14 ` Håvard Skinnemoen
2011-08-17 9:48 ` Matt Fleming
2011-08-17 4:32 ` Håvard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313488648.3436.126.camel@mfleming-mobl1.ger.corp.intel.com \
--to=matt@console-pimps.org \
--cc=egtvedt@samfundet.no \
--cc=hskinnemoen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®