From: "Eilon Greenstein" <eilong@broadcom.com>
To: "Joe Perches" <joe@perches.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 net-next 3/3] bnx2x: Use pr_fmt and message logging cleanups
Date: Wed, 17 Aug 2011 16:42:28 +0300 [thread overview]
Message-ID: <1313588549.7266.9.camel@lb-tlvb-eilong.il.broadcom.com> (raw)
In-Reply-To: <2d33739418a06602c817d002b30fedd57cbe5f11.1313360101.git.joe@perches.com>
On Sun, 2011-08-14 at 15:16 -0700, Joe Perches wrote:
> Add pr_fmt(fmt) KBUILD_MODNAME ": " to prefix messages with "bnx2x: ".
> Remove #define DP_LEVEL and use pr_notice.
> Repeating KERN_<LEVEL> isn't necessary in multi-line printks.
> printk macro neatening, use fmt and ##__VA_ARGS__.
> Coalesce long formats.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Eilon Greenstein <eilong@broadcom.com>
next prev parent reply other threads:[~2011-08-17 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-14 22:16 [PATCH V2 net-next 0/3] bnx2x: Message " Joe Perches
2011-08-14 22:16 ` [PATCH V2 net-next 1/3] bnx2x: Remove local defines for %pM and mac address Joe Perches
2011-08-17 13:42 ` Eilon Greenstein
2011-08-14 22:16 ` [PATCH V2 net-next 2/3] bnx2x: Coalesce pr_cont uses and fix DP typos Joe Perches
2011-08-17 13:42 ` Eilon Greenstein
2011-08-14 22:16 ` [PATCH V2 net-next 3/3] bnx2x: Use pr_fmt and message logging cleanups Joe Perches
2011-08-17 13:42 ` Eilon Greenstein [this message]
2011-08-17 13:42 ` [PATCH V2 net-next 0/3] bnx2x: Message " Eilon Greenstein
2011-08-17 22:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313588549.7266.9.camel@lb-tlvb-eilong.il.broadcom.com \
--to=eilong@broadcom.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®