From: Joe Perches <joe@perches.com>
To: Marc Dietrich <marvin24@gmx.de>
Cc: Akshay Joshi <me@akshayjoshi.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Jiri Kosina <jkosina@suse.cz>,
Vitaliy Ivanov <vitalivanov@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: nvec: Fixed various style issues.
Date: Thu, 18 Aug 2011 00:30:23 -0700 [thread overview]
Message-ID: <1313652623.32547.56.camel@Joe-Laptop> (raw)
In-Reply-To: <201108180858.58200.marvin24@gmx.de>
On Thu, 2011-08-18 at 08:58 +0200, Marc Dietrich wrote:
> Greg, I haven't yet heard of Joe (a reviewer, see:
> http://driverdev.linuxdriverproject.org/pipermail/devel/2011-August/019217.html)
> for some days now.
Hey Marc.
I thought I was pretty clear in my reviewvand
didn't need to reply further.
I think mixing index # and field comment in the
same style isn't very readable.
It's your code, do what you think best.
cheers, Joe
next prev parent reply other threads:[~2011-08-18 7:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 20:36 Akshay Joshi
2011-08-17 21:17 ` Greg KH
2011-08-17 21:23 ` Akshay Joshi
2011-08-18 18:28 ` Greg KH
2011-08-18 6:58 ` Marc Dietrich
2011-08-18 7:30 ` Joe Perches [this message]
2011-08-18 8:05 ` Marc Dietich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313652623.32547.56.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=me@akshayjoshi.com \
--cc=vitalivanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®