mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Harvey Yang <harvey.huawei.yang@gmail.com>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org, Harvey Yang <harvey.huawei.yang@gmail.com>
Subject: [PATCH 1/1] devtmpfs: Fix section mismatch warning
Date: Sun, 21 Aug 2011 10:44:15 +0800	[thread overview]
Message-ID: <1313894655-3783-1-git-send-email-harvey.huawei.yang@gmail.com> (raw)

drivers/base/built-in.o(.text+0xe554): Section mismatch in reference f
rom the function devtmpfsd() to the variable .init.data:setup_done
The function devtmpfsd() references
the variable __initdata setup_done.
This is often because devtmpfsd lacks a __initdata
annotation or the annotation of setup_done is wrong.

"setup_done" is not used after init. but putting it into initdata section leads a section mismatch warning, so initialize it dynamically in __init function.

Signed-off-by: Harvey Yang <harvey.huawei.yang@gmail.com>
---
 drivers/base/devtmpfs.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c
index 33e1bed..d26b47b 100644
--- a/drivers/base/devtmpfs.c
+++ b/drivers/base/devtmpfs.c
@@ -376,7 +376,6 @@ int devtmpfs_mount(const char *mntdir)
 	return err;
 }
 
-static __initdata DECLARE_COMPLETION(setup_done);
 
 static int handle(const char *name, mode_t mode, struct device *dev)
 {
@@ -430,6 +429,9 @@ out:
  */
 int __init devtmpfs_init(void)
 {
+	struct compiletion setup_done;
+	init_compiletion(&setup_done);
+
 	int err = register_filesystem(&dev_fs_type);
 	if (err) {
 		printk(KERN_ERR "devtmpfs: unable to register devtmpfs "
-- 
1.7.2.5


             reply	other threads:[~2011-08-21  2:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-21  2:44 Harvey Yang [this message]
2011-08-21  3:15 ` Greg KH
2011-08-21  4:31   ` Wanlong Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313894655-3783-1-git-send-email-harvey.huawei.yang@gmail.com \
    --to=harvey.huawei.yang@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®