From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753118Ab1HVPcF (ORCPT ); Mon, 22 Aug 2011 11:32:05 -0400 Received: from merlin.infradead.org ([205.233.59.134]:52501 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751147Ab1HVPcC convert rfc822-to-8bit (ORCPT ); Mon, 22 Aug 2011 11:32:02 -0400 Subject: Re: [RFC][PATCH 2/6] x86, nmi: create new NMI handler routines From: Peter Zijlstra To: Don Zickus Cc: x86@kernel.org, Andi Kleen , Robert Richter , ying.huang@intel.com, LKML , jason.wessel@windriver.com Date: Mon, 22 Aug 2011 17:31:56 +0200 In-Reply-To: <20110822152154.GB2067@redhat.com> References: <1313786266-9585-1-git-send-email-dzickus@redhat.com> <1313786266-9585-3-git-send-email-dzickus@redhat.com> <1314022429.24275.30.camel@twins> <20110822152154.GB2067@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.0.2- Message-ID: <1314027116.24275.70.camel@twins> Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2011-08-22 at 11:21 -0400, Don Zickus wrote: > It does seem odd, but I can change that to strncpy to > be safer. I think kstrdup() exists for this purpose, don't forget to free it when you're done with it though ;-)