From: Julia Lawall <julia@diku.dk>
To: Tigran Aivazian <tigran@aivazian.fsnet.co.uk>
Cc: kernel-janitors@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] arch/x86/kernel/microcode_core.c: add missing platform_device_unregister
Date: Wed, 24 Aug 2011 17:10:52 +0200 [thread overview]
Message-ID: <1314198652-10333-1-git-send-email-julia@diku.dk> (raw)
From: Julia Lawall <julia@diku.dk>
Call platform_device_unregister as in the previous error-handling code.
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This is not tested, but I couldn't see how else platform_device_unregister
could be called.
arch/x86/kernel/microcode_core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/microcode_core.c b/arch/x86/kernel/microcode_core.c
index f924280..1872a3a 100644
--- a/arch/x86/kernel/microcode_core.c
+++ b/arch/x86/kernel/microcode_core.c
@@ -532,8 +532,10 @@ static int __init microcode_init(void)
}
error = microcode_dev_init();
- if (error)
+ if (error) {
+ platform_device_unregister(microcode_pdev);
return error;
+ }
register_syscore_ops(&mc_syscore_ops);
register_hotcpu_notifier(&mc_cpu_notifier);
next reply other threads:[~2011-08-24 15:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 15:10 Julia Lawall [this message]
2011-08-24 15:36 ` Borislav Petkov
2011-08-24 15:44 ` Julia Lawall
2011-08-24 16:33 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314198652-10333-1-git-send-email-julia@diku.dk \
--to=julia@diku.dk \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tigran@aivazian.fsnet.co.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®