From: Zhao Jin <cronozhj@gmail.com>
To: cl@linux-foundation.org, penberg@kernel.org, mpm@selenic.com
Cc: linux-kernel@vger.kernel.org, Zhao Jin <cronozhj@gmail.com>
Subject: [PATCH 2/2][RESEND] slab: avoid unnecessary touching of a partial slab
Date: Sat, 27 Aug 2011 00:28:15 +0800 [thread overview]
Message-ID: <1314376095-14991-1-git-send-email-cronozhj@gmail.com> (raw)
In cache_alloc_refill(), after refilling from a partial slab, if the
slab remains partial, it would be deleted from and then added again to
the partial list. As the slab is the first element in the list before
deletion, such behavior has no effect. This patch avoids touching the
slab in this case.
Signed-off-by: Zhao Jin <cronozhj@gmail.com>
---
mm/slab.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/mm/slab.c b/mm/slab.c
index 82e0a0e..2d7a0f4 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -3121,11 +3121,10 @@ retry:
check_slabp(cachep, slabp);
/* move slabp to correct slabp list: */
- list_del(&slabp->list);
if (slabp->free == BUFCTL_END)
- list_add(&slabp->list, &l3->slabs_full);
- else
- list_add(&slabp->list, &l3->slabs_partial);
+ list_move(entry, &l3->slabs_full);
+ else if (entry != l3->slabs_partial.next)
+ list_move(entry, &l3->slabs_partial);
}
must_grow:
--
1.7.4.1
next reply other threads:[~2011-08-26 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 16:28 Zhao Jin [this message]
2012-01-23 13:22 ` Pekka Enberg
2012-01-23 14:48 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314376095-14991-1-git-send-email-cronozhj@gmail.com \
--to=cronozhj@gmail.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®