From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752176Ab1HZWOo (ORCPT <rfc822;w@1wt.eu>);
	Fri, 26 Aug 2011 18:14:44 -0400
Received: from wondertoys-mx.wondertoys.net ([206.117.179.246]:47253 "EHLO
	labridge.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1750828Ab1HZWOn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 26 Aug 2011 18:14:43 -0400
Subject: Re: [PATCH 0/4] dynamic debug: cleanups + compile fix
From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@suse.de>
Cc: Jason Baron <jbaron@redhat.com>, Greg KH <greg@kroah.com>,
        jim.cromie@gmail.com, bvanassche@acm.org, rdunlap@xenotime.net,
        linux-kernel@vger.kernel.org
In-Reply-To: <20110826190417.GA30356@suse.de>
References: <cover.1314291909.git.jbaron@redhat.com>
	 <20110826182900.GA30226@kroah.com> <20110826184742.GA2469@redhat.com>
	 <20110826190417.GA30356@suse.de>
Content-Type: text/plain; charset="UTF-8"
Date: Fri, 26 Aug 2011 15:14:41 -0700
Message-ID: <1314396881.9624.8.camel@Joe-Laptop>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.2 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2011-08-26 at 12:04 -0700, Greg KH wrote:
> On Fri, Aug 26, 2011 at 02:47:42PM -0400, Jason Baron wrote:
> > On Fri, Aug 26, 2011 at 11:29:00AM -0700, Greg KH wrote:
> > > On Thu, Aug 25, 2011 at 01:34:06PM -0400, Jason Baron wrote:
> > > > Hi,
> > > > 
> > > > This is a re-post of the last 3 patches, as requested by Greg:
> > > > https://lkml.org/lkml/2011/8/11/378
> > > > 
> > > > I've also added a compile fix that Randy Dunlap found in the -next tree.
> > > 
> > > Care to redo this based on the comments received so far?
> > > 
> > 
> > Hi,
> > 
> > I re-posted 3/4 based on the comments already. The comment on patch #1
> > regarding adding macro parenthesis, I don't believe makes any functional
> > change...do you still need a re-post the series?
> 
> Yes, please fix patch #1 adding the needed parenthesis and resend the
> whole series.

The parentheses aren't need.

A macro like
#define foo(a, b) a = b

that only uses each argument once without doing arithmetic
gains nothing from parentheses.

Just like
#define true 1
gains nothing from parenthesis either.