From: Eric Dumazet <eric.dumazet@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
tim.c.chen@linux.intel.com, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/3] broadcast-tick: Move oneshot broadcast mask to per cpu variables
Date: Sat, 27 Aug 2011 00:48:42 +0200 [thread overview]
Message-ID: <1314398922.3036.2.camel@edumazet-laptop> (raw)
In-Reply-To: <1314397924-10236-2-git-send-email-andi@firstfloor.org>
Le vendredi 26 août 2011 à 15:32 -0700, Andi Kleen a écrit :
> From: Andi Kleen <ak@linux.intel.com>
>
> Avoid a global cache line hotspot in the oneshot cpu mask. Maintain
> this information in per cpu variables instead.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>
> -/* FIXME: use cpumask_var_t. */
> -static DECLARE_BITMAP(tick_broadcast_oneshot_mask, NR_CPUS);
> +struct broadcast_cpu_state {
> + int need_oneshot;
> +} ____cacheline_aligned;
> +static DEFINE_PER_CPU(struct broadcast_cpu_state, state);
static DEFINE_PER_CPU_ALIGNED(...)
It avoids adding an alignment requirement on .data..percpu
next prev parent reply other threads:[~2011-08-26 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 22:32 [PATCH 1/3] clockevents: Use an atomic RCU notifier for clockevents Andi Kleen
2011-08-26 22:32 ` [PATCH 2/3] broadcast-tick: Move oneshot broadcast mask to per cpu variables Andi Kleen
2011-08-26 22:48 ` Eric Dumazet [this message]
2011-08-26 22:32 ` [PATCH 3/3] tick-broadcast: push down tick_broadcast_lock Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314398922.3036.2.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®