From: Namhyung Kim <namhyung@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/6] block: introduce __bio_endio()
Date: Mon, 29 Aug 2011 12:47:36 +0900 [thread overview]
Message-ID: <1314589660-2918-3-git-send-email-namhyung@gmail.com> (raw)
In-Reply-To: <1314589660-2918-1-git-send-email-namhyung@gmail.com>
Currently, bio_endio() lacks its completion tracepoint in it,
so that the bio-based devices - except DM which inserted the
tracepoint explicitly - cannot send us such an event when using
blktrace. Adding the tracepoint in the function will fix this.
However, bio_endio() is also used for other ways like some
nested bio-handling path and request-based devices. Simply
adding will result in duplicated event for those cases. Thus
add new __bio_endio() function to do things as before but no
tracepoint. Similarly, __bio_io_error() helper was added too.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
block/blk-core.c | 4 ++--
fs/bio.c | 19 +++++++++++++++++++
include/linux/bio.h | 2 ++
3 files changed, 23 insertions(+), 2 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index a60b46cc9da5..62b79692c7e8 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -172,7 +172,7 @@ static void req_bio_endio(struct request *rq, struct bio *bio,
/* don't actually finish bio if it's part of flush sequence */
if (bio->bi_size == 0 && !(rq->cmd_flags & REQ_FLUSH_SEQ))
- bio_endio(bio, error);
+ __bio_endio(bio, error);
}
void blk_dump_rq_flags(struct request *rq, char *msg)
@@ -1551,7 +1551,7 @@ static inline void __generic_make_request(struct bio *bio)
return;
end_io:
- bio_endio(bio, err);
+ __bio_endio(bio, err);
}
/*
diff --git a/fs/bio.c b/fs/bio.c
index 9bfade8a609b..9d7403f53efb 100644
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -1426,6 +1426,21 @@ void bio_flush_dcache_pages(struct bio *bi)
EXPORT_SYMBOL(bio_flush_dcache_pages);
#endif
+/*
+ * no-trace version of bio_endio().
+ */
+void __bio_endio(struct bio *bio, int error)
+{
+ if (error)
+ clear_bit(BIO_UPTODATE, &bio->bi_flags);
+ else if (!test_bit(BIO_UPTODATE, &bio->bi_flags))
+ error = -EIO;
+
+ if (bio->bi_end_io)
+ bio->bi_end_io(bio, error);
+}
+EXPORT_SYMBOL(__bio_endio);
+
/**
* bio_endio - end I/O on a bio
* @bio: bio
@@ -1442,11 +1457,15 @@ EXPORT_SYMBOL(bio_flush_dcache_pages);
**/
void bio_endio(struct bio *bio, int error)
{
+ struct request_queue *q = bdev_get_queue(bio->bi_bdev);
+
if (error)
clear_bit(BIO_UPTODATE, &bio->bi_flags);
else if (!test_bit(BIO_UPTODATE, &bio->bi_flags))
error = -EIO;
+ trace_block_bio_complete(q, bio, error);
+
if (bio->bi_end_io)
bio->bi_end_io(bio, error);
}
diff --git a/include/linux/bio.h b/include/linux/bio.h
index ce33e6868a2f..453a9bec49b8 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -132,6 +132,7 @@ static inline int bio_has_allocated_vec(struct bio *bio)
#define BIO_SEG_BOUNDARY(q, b1, b2) \
BIOVEC_SEG_BOUNDARY((q), __BVEC_END((b1)), __BVEC_START((b2)))
+#define __bio_io_error(bio) __bio_endio((bio), -EIO)
#define bio_io_error(bio) bio_endio((bio), -EIO)
/*
@@ -217,6 +218,7 @@ extern struct bio *bio_alloc_bioset(gfp_t, int, struct bio_set *);
extern void bio_put(struct bio *);
extern void bio_free(struct bio *, struct bio_set *);
+extern void __bio_endio(struct bio *, int);
extern void bio_endio(struct bio *, int);
struct request_queue;
extern int bio_phys_segments(struct request_queue *, struct bio *);
--
1.7.6
next prev parent reply other threads:[~2011-08-29 3:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 3:47 [PATCH 0/6] blktrace: bio-based device tracing improvement Namhyung Kim
2011-08-29 3:47 ` [PATCH 1/6] block: move trace_block_bio_remap() before blk_partition_remap Namhyung Kim
2011-08-29 3:47 ` Namhyung Kim [this message]
2011-08-30 19:15 ` [PATCH 2/6] block: introduce __bio_endio() Jens Axboe
2011-09-01 1:43 ` Namhyung Kim
2011-08-29 3:47 ` [PATCH 3/6] bounce: convert to __bio_endio() for bounced bio's Namhyung Kim
2011-08-29 3:47 ` [PATCH 4/6] bio-integrity: convert to __bio_endio() Namhyung Kim
2011-08-29 3:47 ` [PATCH 5/6] Btrfs: " Namhyung Kim
2011-08-29 3:47 ` [PATCH 6/6] dm: get rid of block_bio_complete tracepoint Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314589660-2918-3-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®