From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753980Ab1H2QEX (ORCPT ); Mon, 29 Aug 2011 12:04:23 -0400 Received: from a.ns.miles-group.at ([95.130.255.143]:34798 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753847Ab1H2QET (ORCPT ); Mon, 29 Aug 2011 12:04:19 -0400 From: Richard Weinberger To: akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, =?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= , Richard Weinberger Subject: [PATCH 2/9] um: drivers/xterm.c: fix a file descriptor leak Date: Mon, 29 Aug 2011 18:03:55 +0200 Message-Id: <1314633842-24515-3-git-send-email-richard@nod.at> X-Mailer: git-send-email 1.7.6.1 In-Reply-To: <1314633842-24515-1-git-send-email-richard@nod.at> References: <1314633842-24515-1-git-send-email-richard@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jonathan Neuschäfer I could use out_close1, but that seems to be the code path to close the fd returned by os_create_unix_socket, and using it to close the fd returned by mkstemp might lead to some confusion, so I don't do it. Signed-off-by: Jonathan Neuschäfer Signed-off-by: Richard Weinberger --- arch/um/drivers/xterm.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/um/drivers/xterm.c b/arch/um/drivers/xterm.c index 8ac7146..2e1de57 100644 --- a/arch/um/drivers/xterm.c +++ b/arch/um/drivers/xterm.c @@ -123,6 +123,7 @@ static int xterm_open(int input, int output, int primary, void *d, err = -errno; printk(UM_KERN_ERR "xterm_open : unlink failed, errno = %d\n", errno); + close(fd); return err; } close(fd); -- 1.7.6.1