mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: gregkh@suse.de
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	jirislaby@gmail.com, Alan Cox <alan@linux.intel.com>
Subject: [PATCH 3/4] TTY: serial, fix build of some drivers
Date: Wed, 31 Aug 2011 21:24:58 +0200	[thread overview]
Message-ID: <1314818699-10873-3-git-send-email-jslaby@suse.cz> (raw)
In-Reply-To: <1314818699-10873-1-git-send-email-jslaby@suse.cz>

I'm getting build errors such as:
.../tty/serial/max3107.c: In function ‘put_data_to_circ_buf’:
.../tty/serial/max3107.c:149:2: error: implicit declaration of function ‘tty_insert_flip_string’

Those drivers need to include linux/tty_flip.h. The question is
whether we want to fix them at all. As they are broken for some time
already and nobody noticed...

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@linux.intel.com>
---
 drivers/tty/serial/max3107.c  |    1 +
 drivers/tty/serial/timbuart.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/tty/serial/max3107.c b/drivers/tty/serial/max3107.c
index a50f406..a33ff77 100644
--- a/drivers/tty/serial/max3107.c
+++ b/drivers/tty/serial/max3107.c
@@ -35,6 +35,7 @@
 #include <linux/spi/spi.h>
 #include <linux/freezer.h>
 #include <linux/module.h>
+#include <linux/tty_flip.h>
 #include "max3107.h"
 
 static const struct baud_table brg26_ext[] = {
diff --git a/drivers/tty/serial/timbuart.c b/drivers/tty/serial/timbuart.c
index e213535..3a4da87 100644
--- a/drivers/tty/serial/timbuart.c
+++ b/drivers/tty/serial/timbuart.c
@@ -28,6 +28,7 @@
 #include <linux/ioport.h>
 #include <linux/slab.h>
 #include <linux/module.h>
+#include <linux/tty_flip.h>
 
 #include "timbuart.h"
 
-- 
1.7.6.1



  parent reply	other threads:[~2011-08-31 19:25 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31 19:24 [PATCH 1/4] TTY: serial, fix locking imbalance Jiri Slaby
2011-08-31 19:24 ` [PATCH 2/4] TTY: serial, remove dead code from 68328 Jiri Slaby
2011-08-31 19:51   ` Geert Uytterhoeven
2011-08-31 19:51     ` Geert Uytterhoeven
2011-08-31 19:24 ` Jiri Slaby [this message]
2011-08-31 21:28   ` [PATCH 3/4] TTY: serial, fix build of some drivers Alan Cox
2011-09-01  8:29     ` Jiri Slaby
2011-09-01 14:20   ` [PATCH v2 3/4] TTY: serial, fix includes in " Jiri Slaby
2011-08-31 19:24 ` [PATCH 4/4] TTY: serial, move 68360 driver to staging Jiri Slaby
2011-08-31 19:31   ` Sasha Levin
2011-08-31 19:37     ` [PATCH "find-renames version" " Jiri Slaby
2011-08-31 19:41     ` [PATCH " Greg KH
2011-08-31 19:52   ` Geert Uytterhoeven
2011-09-22 18:30 ` [PATCH 1/4] TTY: serial, fix locking imbalance Jiri Slaby
2011-09-22 18:38   ` Greg KH
2011-09-22 22:46 ` Greg KH
2011-09-23 18:52   ` Jiri Slaby
2011-09-23 19:08     ` Greg KH
2011-09-23 19:21       ` Jiri Slaby
2011-09-23 22:04         ` Greg KH
2011-09-24 17:50           ` Jiri Slaby
2011-09-26 23:36             ` Greg KH
2011-09-27  8:26               ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314818699-10873-3-git-send-email-jslaby@suse.cz \
    --to=jslaby@suse.cz \
    --cc=alan@linux.intel.com \
    --cc=gregkh@suse.de \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®