From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753577Ab1HaTlX (ORCPT ); Wed, 31 Aug 2011 15:41:23 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:45657 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752543Ab1HaTlS (ORCPT ); Wed, 31 Aug 2011 15:41:18 -0400 From: Stephen Warren To: Greg Kroah-Hartman , Russell King Cc: Jonathan Cameron , Andrew Chew , Arnd Bergmann , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Stephen Warren Subject: [PATCH 1/3] staging:iio:magnetometer:ak8975 Don't use irq_to_gpio() Date: Wed, 31 Aug 2011 13:40:55 -0600 Message-Id: <1314819657-828-1-git-send-email-swarren@nvidia.com> X-Mailer: git-send-email 1.7.0.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tegra doesn't have irq_to_gpio() any more, and ak8975 is included in tegra_defconfig. This causes a build failure. Solve this with a heavy-handed method for now. I suspect the long-term solution is to pass both the IRQ and GPIO IDs to the driver; the GPIO ID coming from either platform data, or perhaps enhancing struct i2c_client to add a gpio field alongside irq. Signed-off-by: Stephen Warren --- Russell, now that irq_to_gpio() is going away, can you comment on how you'd like to fix drivers that do this kind of thing? Thanks. drivers/staging/iio/magnetometer/ak8975.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/iio/magnetometer/ak8975.c b/drivers/staging/iio/magnetometer/ak8975.c index a17fa9f..bd40e32 100644 --- a/drivers/staging/iio/magnetometer/ak8975.c +++ b/drivers/staging/iio/magnetometer/ak8975.c @@ -477,7 +477,7 @@ static int ak8975_probe(struct i2c_client *client, int err; /* Grab and set up the supplied GPIO. */ - eoc_gpio = irq_to_gpio(client->irq); + eoc_gpio = -1; /* FIXME: irq_to_gpio(client->irq) */ /* We may not have a GPIO based IRQ to scan, that is fine, we will poll if so */ -- 1.7.0.4