From: Glauber Costa <glommer@parallels.com>
To: linux-kernel@vger.kernel.org
Cc: Glauber Costa <glommer@parallels.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Li Zefan <lizf@cn.fujitsu.com>,
"David S. Miller" <davem@davemloft.net>
Subject: [PATCH] cleanup: no need to call rcu_lock in sock_update_classid()
Date: Mon, 5 Sep 2011 23:35:36 -0300 [thread overview]
Message-ID: <1315276536-10910-1-git-send-email-glommer@parallels.com> (raw)
There is no need to protect
According to the all-knowing git log, this was inserted here to prevent a
warning in commit 1144182a. But 3fb5a991 also does that in a different place.
>From reading it, I believe they are fixing the same warning, so no need
for both.
Signed-off-by: Glauber Costa <glommer@parallels.com>
CC: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
CC: Li Zefan <lizf@cn.fujitsu.com>
CC: David S. Miller <davem@davemloft.net>
---
net/core/sock.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/net/core/sock.c b/net/core/sock.c
index bc745d0..3449df8 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -1107,9 +1107,7 @@ void sock_update_classid(struct sock *sk)
{
u32 classid;
- rcu_read_lock(); /* doing current task, which cannot vanish. */
classid = task_cls_classid(current);
- rcu_read_unlock();
if (classid && classid != sk->sk_classid)
sk->sk_classid = classid;
}
--
1.7.6
next reply other threads:[~2011-09-06 2:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 2:35 Glauber Costa [this message]
2011-09-08 17:26 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315276536-10910-1-git-send-email-glommer@parallels.com \
--to=glommer@parallels.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®