From: Nitin Gupta <ngupta@vflare.org>
To: Greg KH <greg@kroah.com>
Cc: Jerome Marchand <jmarchan@redhat.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Robert Jennings <rcj@linux.vnet.ibm.com>,
Linux Driver Project <devel@linuxdriverproject.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/5] Kernel config option for number of devices
Date: Thu, 8 Sep 2011 08:29:14 +0700 [thread overview]
Message-ID: <1315445357-14338-3-git-send-email-ngupta@vflare.org> (raw)
In-Reply-To: <1315445357-14338-1-git-send-email-ngupta@vflare.org>
Allows configuring default number of zram devices
as kernel config option. User can override this
value using 'num_devices' module parameter.
Signed-off-by: Nitin Gupta <ngupta@vflare.org>
---
drivers/staging/zram/Kconfig | 9 +++++++++
drivers/staging/zram/zram_drv.c | 13 ++++++++-----
2 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/zram/Kconfig b/drivers/staging/zram/Kconfig
index 3bec4db..ca31cb3 100644
--- a/drivers/staging/zram/Kconfig
+++ b/drivers/staging/zram/Kconfig
@@ -21,6 +21,15 @@ config ZRAM
See zram.txt for more information.
Project home: http://compcache.googlecode.com/
+config ZRAM_NUM_DEVICES
+ int "Default number of zram devices"
+ depends on ZRAM
+ range 1 32
+ default 1
+ help
+ Select default number of zram devices. You can override this value
+ using 'num_devices' module parameter.
+
config ZRAM_DEBUG
bool "Compressed RAM block device debug support"
depends on ZRAM
diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
index 03ec5a2..55f2c0e 100644
--- a/drivers/staging/zram/zram_drv.c
+++ b/drivers/staging/zram/zram_drv.c
@@ -781,6 +781,14 @@ static int __init zram_init(void)
{
int ret, dev_id;
+ /*
+ * Module parameter not specified by user. Use default
+ * value as defined during kernel config.
+ */
+ if (num_devices == 0) {
+ num_devices = CONFIG_ZRAM_NUM_DEVICES;
+ }
+
if (num_devices > max_num_devices) {
pr_warning("Invalid value for num_devices: %u\n",
num_devices);
@@ -795,11 +803,6 @@ static int __init zram_init(void)
goto out;
}
- if (!num_devices) {
- pr_info("num_devices not specified. Using default: 1\n");
- num_devices = 1;
- }
-
/* Allocate the device array and initialize each one */
pr_info("Creating %u devices ...\n", num_devices);
devices = kzalloc(num_devices * sizeof(struct zram), GFP_KERNEL);
--
1.7.6
next prev parent reply other threads:[~2011-09-08 1:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 1:29 [PATCH 0/5 v2] zram: minor features and cleanups Nitin Gupta
2011-09-08 1:29 ` [PATCH 1/5] Fix sparse warnings Nitin Gupta
2011-09-08 8:17 ` Jerome Marchand
2011-09-08 15:13 ` Nitin Gupta
2011-09-08 17:32 ` Harvey Harrison
2011-09-09 17:00 ` Nitin Gupta
2011-09-09 17:11 ` Dan Carpenter
2011-09-09 17:19 ` [PATCH 1/5 resend] " Nitin Gupta
2011-09-09 20:30 ` Greg KH
2011-09-08 1:29 ` Nitin Gupta [this message]
2011-09-08 1:29 ` [PATCH 3/5] Make gobal variables use unique names Nitin Gupta
2011-09-08 1:29 ` [PATCH 4/5] Simplify zram disk resizing interface Nitin Gupta
2011-09-08 1:29 ` [PATCH 5/5] Set initial disksize to some default value Nitin Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315445357-14338-3-git-send-email-ngupta@vflare.org \
--to=ngupta@vflare.org \
--cc=devel@linuxdriverproject.org \
--cc=greg@kroah.com \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=rcj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®