mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pawel Moll <pawel.moll@arm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	"Michael S.Tsirkin" <mst@redhat.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-kernel@vger.kernel.org,
	virtualization <virtualization@lists.linux-foundation.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC 1/2] virtio: Add AMBA bus driver for virtio device
Date: Tue, 13 Sep 2011 10:40:32 +0100	[thread overview]
Message-ID: <1315906832.3297.41.camel@hornet.cambridge.arm.com> (raw)
In-Reply-To: <87hb4h408d.fsf@rustcorp.com.au>

> > No problem, I've reserved 128 bits in the modified registers layout (see
> > RFC v2), I can even change it into "offset/value" interface, which would
> > give you variable width. One thing I don't get is how to access feature
> > bits > 31? The get_features() seems
> > to be limited to 32:
> > 
> > struct virtio_config_ops {
> > <...>
> > 	u32 (*get_features)(struct virtio_device *vdev);
> > <...>
> > }
> 
> There's a patch for that already :)

Ok, so how about one of the following two options:

1. 4 * 32-bit words of feature flags, 128 bits in total:

 *  0x010   32  HostFeatures0  Features supported by the host, bits 0-31
 *  0x014   32  HostFeatures1  Features supported by the host, bits 32-63
 *  0x018   32  HostFeatures2  Features supported by the host, bits 64-95
 *  0x01c   32  HostFeatures3  Features supported by the host, bits 96-127

 *  0x020   32  GuestFeatures0 Features activated by the guest, bits 0-31
 *  0x024   32  GuestFeatures1 Features activated by the guest, bits 32-63
 *  0x028   32  GuestFeatures2 Features activated by the guest, bits 64-95
 *  0x02c   32  GuestFeatures3 Features activated by the guest, bits 96-127

2. "Select word -> read flags" interface:

 *  0x010   32  HostFeaturesFlags  Features supported by the host
 *  0x014   32  HostFeaturesWord   Set of features to access

 *  0x020   32  GuestFeaturesFlags Features activated by the guest
 *  0x024   32  GuestFeaturesWord  Set of features to set

In this case the algorithm would be:

	writel(0, HostFeaturesWord);
	bits_0_31 = readl(HostFeaturesFlags);
	writel(1, HostFeaturesWord);
	bits_32_63 = readl(HostFeaturesFlags);
	<etc>

The latter seems more "future-proof" to me, if slightly more complex...
Any other suggestions?

> > > > + *  0x008   32  QueuePFN      PFN for the currently selected queue
> > > > + *  0x00c   32  QueueNum      Queue size for the currently selected queue
> > > 
> > > You should, I believe, seriously consider allowing the guest to set the
> > > queue size, rather than the host (perhaps the host could suggest one,
> > > but the guest should be able to override it).
> > 
> > I guess the QueueNum could be simply a read/write register - guest can
> > read suggestion and override it writing it back. The same question
> > though - how can guest change it? (I mean some API?)
> 
> We can sort that out later... the Guest may try some ambitious large
> allocation and fall back if it fails.

So, to my mind, the negotiations could look like this (from the Guest's
point of view):

1. (optional) The Guest is asking what size is "suggested" by the Host:

	size = readl(QueueNum);

2. The Guest requests size it would like to use:

	writel(optimal_size(size), QueueNum);

3. The Host does the best it can to accommodate the Guest and the Guest
checks the effective size:

	size = real(QueueNum);

Does it make some sense?

> > > Anthony or Michael might suggest other changes, since they are most
> > > familiar with virtio_pci limitations...
> > 
> > I've added them on the RFC v2 Cc as well - all feedback more then
> > welcome!
> 
> Excellent...  of course, the virtualization list is down at the moment,
> making this a bit more awkward.

Haha - at least once I can't blame our corporate IT for making my job
harder ;-)

Cheers!

Paweł


  reply	other threads:[~2011-09-13  9:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-02 12:24 [RFC 0/2] Memory mapped " Pawel Moll
2011-09-02 12:24 ` [RFC 1/2] virtio: Add AMBA bus driver for " Pawel Moll
     [not found]   ` <877h5e5yxp.fsf@rustcorp.com.au>
2011-09-12 16:45     ` Pawel Moll
2011-09-12 16:51       ` [RFC v2] arm: Add platform " Pawel Moll
2011-09-12 17:27         ` Anthony Liguori
2011-09-13  8:58           ` Pawel Moll
2011-09-13  2:58       ` [RFC 1/2] virtio: Add AMBA " Rusty Russell
2011-09-13  9:40         ` Pawel Moll [this message]
2011-09-14  0:18           ` Rusty Russell
2011-09-14 16:47             ` Pawel Moll
2011-09-02 12:24 ` [RFC 2/2] ARM: Add VIRTUALIZATION configuration menu and virtio options Pawel Moll

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1315906832.3297.41.camel@hornet.cambridge.arm.com \
    --to=pawel.moll@arm.com \
    --cc=aliguori@us.ibm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mst@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®