From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754259Ab1IMOPe (ORCPT ); Tue, 13 Sep 2011 10:15:34 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:57994 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753291Ab1IMOPb (ORCPT ); Tue, 13 Sep 2011 10:15:31 -0400 From: Konrad Rzeszutek Wilk To: thellstrom@vmware.com, linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, dri-devel@lists.freedesktop.org, thomas@shipmail.org Cc: Pekka Paalanen , bskeggs@redhat.com, j.glisse@redhat.com, airlied@redhat.com, airlied@linux.ie, alexdeucher@gmail.com Subject: [PATCH] TTM DMA v1.8 Date: Tue, 13 Sep 2011 10:12:43 -0400 Message-Id: <1315923170-25568-1-git-send-email-konrad.wilk@oracle.com> X-Mailer: git-send-email 1.7.4.1 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090202.4E6F64F3.0045:SCFMA922111,ss=1,re=-4.000,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since v1.7: [https://lkml.org/lkml/2011/8/30/460] - Fixed checking the DMA address in radeon/nouveau code. Since v1: [http://lwn.net/Articles/456246/] - Ran it through the gauntlet of SubmitChecklist and fixed issues - Made radeon/nouveau driver set coherent_dma (which is required for dmapool) [.. and this is what I said in v1 post]: Way back in January this patchset: http://lists.freedesktop.org/archives/dri-devel/2011-January/006905.html was merged in, but pieces of it had to be reverted b/c they did not work properly under PowerPC, ARM, and when swapping out pages to disk. After a bit of discussion on the mailing list http://marc.info/?i=4D769726.2030307@shipmail.org I started working on it, but got waylaid by other things .. and finally I am able to post the RFC patches. There was a lot of discussion about it and I am not sure if I captured everybody's thoughts - if I did not - that is _not_ intentional - it has just been quite some time.. Anyhow .. the patches explore what the "lib/dmapool.c" does - which is to have a DMA pool that the device has associated with. I kind of married that code along with drivers/gpu/drm/ttm/ttm_page_alloc.c to create a TTM DMA pool code. The end result is DMA pool with extra features: can do write-combine, uncached, writeback (and tracks them and sets back to WB when freed); tracks "cached" pages that don't really need to be returned to a pool; and hooks up to the shrinker code so that the pools can be shrunk. If you guys think this set of patches make sense - my future plans were 1) Get this in large crowd of testing .. and if it works for a kernel release 2) to move a bulk of this in the lib/dmapool.c (I spoke with Matthew Wilcox about it and he is OK as long as I don't introduce performance regressions). But before I do any of that a second set of eyes taking a look at these patches would be most welcome. In regards to testing, I've been running them non-stop for the last two weeks (and found some issues which I've fixed up) - and been quite happy with how they work. I finally got my Intel VT-d box online so will test that shortly. Michel (thanks!) took a spin of the patches on his PowerPC and they did not cause any regressions (wheew). The patches are also located in a git tree: git://oss.oracle.com/git/kwilk/xen.git devel/ttm.dma_pool.v1.8 drivers/gpu/drm/nouveau/nouveau_mem.c | 8 +- drivers/gpu/drm/nouveau/nouveau_sgdma.c | 3 +- drivers/gpu/drm/radeon/radeon_device.c | 6 + drivers/gpu/drm/radeon/radeon_gart.c | 4 +- drivers/gpu/drm/radeon/radeon_ttm.c | 3 +- drivers/gpu/drm/ttm/Makefile | 3 + drivers/gpu/drm/ttm/ttm_bo.c | 4 +- drivers/gpu/drm/ttm/ttm_memory.c | 5 + drivers/gpu/drm/ttm/ttm_page_alloc.c | 63 ++- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 1317 ++++++++++++++++++++++++++++++ drivers/gpu/drm/ttm/ttm_tt.c | 5 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 4 +- drivers/xen/swiotlb-xen.c | 2 +- include/drm/ttm/ttm_bo_driver.h | 7 +- include/drm/ttm/ttm_page_alloc.h | 100 +++- include/linux/swiotlb.h | 7 +- lib/swiotlb.c | 5 +- 17 files changed, 1516 insertions(+), 30 deletions(-)