From: Eric Dumazet <eric.dumazet@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Thomas Meyer <thomas@m3y3r.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sys_poll(): fix function definition/negative timeout values
Date: Thu, 15 Sep 2011 20:21:02 +0200 [thread overview]
Message-ID: <1316110862.2492.10.camel@edumazet-laptop> (raw)
In-Reply-To: <20110915181242.GZ7761@one.firstfloor.org>
Le jeudi 15 septembre 2011 à 20:12 +0200, Andi Kleen a écrit :
> On Thu, Sep 15, 2011 at 08:05:17PM +0200, Eric Dumazet wrote:
> > Le jeudi 15 septembre 2011 à 10:47 -0700, Andi Kleen a écrit :
> > > Thomas Meyer <thomas@m3y3r.de> writes:
> > >
> > > > Fix negative timeout values for x86 userland on x86_64 kernels.
> > > > Align sys_poll() definition to glibc's definition.
> > >
> > > Nack. Please write a compat wrapper that sign extends.
> > >
> >
> > Why ?
>
> Because we shouldn't change existing interfaces and there could
> be valid reasons on 64bit for really long delays.
I disagree.
Existing interface and POSIX mandates "int delay"
The kernel part of the contract was fine when we supported 32bit only
machines, by chance, because sizeof(int) == sizeof(long).
If you want more than 31 bits delay, then we need a new interface, and
this new interface must also work on 32bit arches (sort of poll64())
next prev parent reply other threads:[~2011-09-15 18:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 12:45 Thomas Meyer
2011-09-15 17:47 ` Andi Kleen
2011-09-15 18:05 ` Eric Dumazet
2011-09-15 18:12 ` Andi Kleen
2011-09-15 18:21 ` Eric Dumazet [this message]
2011-10-06 23:01 ` Andrew Morton
2011-09-16 17:04 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316110862.2492.10.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®