mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org,
	Lars-Peter Clausen <lars@metafoo.de>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 5/5] regmap: Fix hookup of regcache into regmap
Date: Mon, 19 Sep 2011 19:03:44 +0100	[thread overview]
Message-ID: <1316455424-11173-5-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1316455424-11173-1-git-send-email-broonie@opensource.wolfsonmicro.com>

- Only suppress physical writes if we're in cache only mode
- Use the cache for all reads, not just internal ones
- Return -EBUSY if we're in cache only mode.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 drivers/base/regmap/regmap.c |   21 ++++++++++++---------
 1 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index 602083f..3596465 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -304,7 +304,9 @@ static int _regmap_write(struct regmap *map, unsigned int reg,
 
 	if (!map->cache_bypass) {
 		ret = regcache_write(map, reg, val);
-		if (!ret || map->cache_only)
+		if (ret != 0)
+			return ret;
+		if (map->cache_only)
 			return 0;
 	}
 
@@ -421,6 +423,15 @@ static int _regmap_read(struct regmap *map, unsigned int reg,
 	if (!map->format.parse_val)
 		return -EINVAL;
 
+	if (!map->cache_bypass) {
+		ret = regcache_read(map, reg, val);
+		if (ret == 0)
+			return 0;
+	}
+
+	if (map->cache_only)
+		return -EBUSY;
+
 	ret = _regmap_raw_read(map, reg, map->work_buf, map->format.val_bytes);
 	if (ret == 0) {
 		*val = map->format.parse_val(map->work_buf);
@@ -446,14 +457,6 @@ int regmap_read(struct regmap *map, unsigned int reg, unsigned int *val)
 
 	mutex_lock(&map->lock);
 
-	if (!map->cache_bypass) {
-		ret = regcache_read(map, reg, val);
-		if (!ret) {
-			mutex_unlock(&map->lock);
-			return 0;
-		}
-	}
-
 	ret = _regmap_read(map, reg, val);
 
 	mutex_unlock(&map->lock);
-- 
1.7.6.3


  parent reply	other threads:[~2011-09-19 18:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-19 13:33 [PATCH 0/6 v5] Introduce caching support for regmap Dimitris Papastamos
2011-09-19 13:34 ` [PATCH 1/6 v5] regmap: Introduce caching support Dimitris Papastamos
2011-09-19 13:34 ` [PATCH 2/6 v5] regmap: Add the indexed cache support Dimitris Papastamos
2011-09-19 13:34 ` [PATCH 3/6 v5] regmap: Add the rbtree " Dimitris Papastamos
2011-09-19 13:34 ` [PATCH 4/6 v5] regmap: Add the LZO " Dimitris Papastamos
2011-09-19 13:34 ` [PATCH 5/6 v5] regmap: Add the regcache_sync trace event Dimitris Papastamos
2011-09-19 13:34 ` [PATCH 6/6 v5] regmap: Incorporate the regcache core into regmap Dimitris Papastamos
2011-09-19 15:57   ` Lars-Peter Clausen
2011-09-19 16:13     ` Mark Brown
2011-09-19 16:20       ` Dimitris Papastamos
2011-09-19 16:28       ` Lars-Peter Clausen
2011-09-19 16:36         ` Mark Brown
2011-09-19 17:59 ` [PATCH 0/6 v5] Introduce caching support for regmap Mark Brown
2011-09-19 18:03   ` [PATCH 1/5] regmap: A cache type of _NONE behaves like a bypassed cache Mark Brown
2011-09-19 18:03     ` [PATCH 2/5] regmap: Prototype regcache_sync() Mark Brown
2011-09-19 18:03     ` [PATCH 3/5] regmap: Allow drivers to control cache_only flag Mark Brown
2011-09-19 18:03     ` [PATCH 4/5] regmap: Indentation tweaks in regcache Mark Brown
2011-09-19 18:03     ` Mark Brown [this message]
2011-09-19 18:04   ` [PATCH 0/6 v5] Introduce caching support for regmap Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316455424-11173-5-git-send-email-broonie@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®