From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752713Ab1IUHyF (ORCPT ); Wed, 21 Sep 2011 03:54:05 -0400 Received: from sm-d311v.smileserver.ne.jp ([203.211.202.206]:33175 "EHLO sm-d311v.smileserver.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873Ab1IUHyD (ORCPT ); Wed, 21 Sep 2011 03:54:03 -0400 From: Tomoya MORINAGA To: Jean Delvare , Ben Dooks , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Qi Wang , yong.y.wang@intel.com, joel.clark@intel.com, kok.howg.ewe@intel.com, toshiharu-linux@dsn.okisemi.com, Tomoya MORINAGA Subject: [PATCH 1/7] i2c-eg20t: Fix bus-idle waiting issue Date: Wed, 21 Sep 2011 16:51:43 +0900 Message-Id: <1316591509-4433-1-git-send-email-tomoya-linux@dsn.okisemi.com> X-Mailer: git-send-email 1.7.4.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, when checking whether bus is idle or not, if timeout occurs, this function always returns success(zero). This patch fixes the issue. Signed-off-by: Tomoya MORINAGA --- drivers/i2c/busses/i2c-eg20t.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c index 6565009..6add59f 100644 --- a/drivers/i2c/busses/i2c-eg20t.c +++ b/drivers/i2c/busses/i2c-eg20t.c @@ -286,7 +286,7 @@ static s32 pch_i2c_wait_for_bus_idle(struct i2c_algo_pch_data *adap, pch_dbg(adap, "I2CSR = %x\n", ioread32(p + PCH_I2CSR)); - if (timeout == 0) { + if (!ktime_lt(ktime_get(), ns_val)) { pch_err(adap, "%s: Timeout Error.return%d\n", __func__, -ETIME); return -ETIME; } -- 1.7.4.4