From: Matt Fleming <matt@console-pimps.org>
To: Maarten Lankhorst <m.b.lankhorst@gmail.com>
Cc: Matt Domsch <Matt_Domsch@Dell.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Matthew Garrett <mjg@redhat.com>,
"x86@kernel.org" <x86@kernel.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Mike Waychison <mikew@google.com>,
Andi Kleen <andi@firstfloor.org>,
"Hargrave, Jordan" <Jordan_Hargrave@Dell.com>
Subject: Re: [PATCH v2 10/10] x86, efi: EFI boot stub support
Date: Wed, 21 Sep 2011 12:57:21 +0100 [thread overview]
Message-ID: <1316606241.5262.15.camel@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <4E748EB2.1000203@gmail.com>
On Sat, 2011-09-17 at 14:12 +0200, Maarten Lankhorst wrote:
> Anyhow it seems the cmdline_size is meant for reading, and setting it
> is completely ignored, see below. Could we make it a static array so
> no allocation needs to be done?
D'oh. Yeah, you're right, there's no point in updating cmdline_size.
What would be the benefit of making cmdline a static array and skipping
the allocation? I doubt it would improve boot time, and we'd end up
making the bzImage larger.
> > Hmm... I'm really not convinced that we need to support ASCII cmdline
> > arguments, sorry. efibootmgr has support for UCS-2, so that's what
> > should be used.
> >
> I know, but this is nicer for displaying, compare this efibootmgr -v output:
>
> Boot0002* Linux ASCII Boot HD(...)File(\vmlinuz.efi)root=/dev/sdb2 console=ttyS0,115200n8.
> Boot0003* Linux UCS-2 Boot HD(...)File(\vmlinuz.efi)r.o.o.t.=./.d.e.v./.s.d.b.2. .c.o.n.s.o.l.e.=.t.t.y.S.0.,.1.1.5.2.0.0.n.8...
>
> And it's more foolproof, since it's easy to pass strings as
> ASCII since it's the default, and it would show up readable in efibootmgr.
But if you don't like the output from efibootmgr, you should fix
efibootmgr, not cram more string manipulation code into the EFI stub.
If there were other cases where an ASCII cmdline was passed to the stub
I'd be more inclined to support it. But if it's just a case of "the EFI
boot stub doesn't parse arguments when efibootmgr passes them as ASCII"
my response is "Pass them as UCS-2 then".
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-09-21 11:57 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 14:34 [PATCH v2 00/10] x86 EFI boot stub Matt Fleming
2011-09-12 14:34 ` [PATCH 01/10] x86: Add missing bzImage fields to struct setup_header Matt Fleming
2011-09-12 14:34 ` [PATCH 02/10] x86, efi: Make efi_call_phys_prelog() CONFIG_RELOCATABLE-aware Matt Fleming
2011-09-12 14:34 ` [PATCH 03/10] x86: Don't use magic strings for EFI loader signature Matt Fleming
2011-09-12 14:34 ` [PATCH 04/10] efi.h: Add struct definition for boot time services Matt Fleming
2011-09-12 14:34 ` [PATCH v2 05/10] efi.h: Add efi_image_loaded_t Matt Fleming
2011-09-12 14:34 ` [PATCH 06/10] efi.h: Add allocation types for boottime->allocate_pages() Matt Fleming
2011-09-12 14:34 ` [PATCH v2 07/10] efi.h: Add graphics protocol guids Matt Fleming
2011-09-12 14:34 ` [PATCH 08/10] efi.h: Add boottime->locate_handle search types Matt Fleming
2011-09-12 14:34 ` [PATCH v2 09/10] efi: Add EFI file I/O data types Matt Fleming
2011-09-12 14:34 ` [PATCH v2 10/10] x86, efi: EFI boot stub support Matt Fleming
2011-09-13 13:29 ` Matthew Garrett
2011-09-13 14:01 ` Matt Fleming
2011-09-13 14:33 ` Maarten Lankhorst
2011-09-14 16:07 ` Matt Fleming
[not found] ` <20110915045231.GA32136@emperor.us.dell.com>
2011-09-15 8:04 ` Maarten Lankhorst
2011-09-15 9:08 ` Maarten Lankhorst
[not found] ` <20110915115255.GA4669@emperor.us.dell.com>
2011-09-15 12:44 ` Maarten Lankhorst
2011-09-17 11:44 ` Matt Fleming
2011-09-17 12:12 ` Maarten Lankhorst
2011-09-21 11:57 ` Matt Fleming [this message]
2011-09-21 12:10 ` [PATCH v3 " Matt Fleming
2011-09-22 11:43 ` Maarten Lankhorst
2011-09-22 11:55 ` Matt Fleming
2011-09-29 10:14 ` Henrik Rydberg
2011-09-30 7:41 ` Matt Fleming
2011-09-30 11:13 ` Henrik Rydberg
2011-10-03 16:53 ` Matthew Garrett
2011-10-03 18:32 ` Henrik Rydberg
2011-09-30 8:51 ` [PATCH v4 " Matt Fleming
2011-09-30 16:24 ` Shea Levy
2011-09-30 20:11 ` Matt Fleming
2011-10-01 7:50 ` Maarten Lankhorst
2011-10-01 9:19 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316606241.5262.15.camel@mfleming-mobl1.ger.corp.intel.com \
--to=matt@console-pimps.org \
--cc=Jordan_Hargrave@Dell.com \
--cc=Matt_Domsch@Dell.com \
--cc=andi@firstfloor.org \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.b.lankhorst@gmail.com \
--cc=mikew@google.com \
--cc=mingo@elte.hu \
--cc=mjg@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®