From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Darren Hart <dvhart@linux.intel.com>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 12/12] perf tools: Add support for disabling -Werror via WERROR=0
Date: Fri, 23 Sep 2011 17:26:26 -0300 [thread overview]
Message-ID: <1316809586-28529-13-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1316809586-28529-1-git-send-email-acme@infradead.org>
From: Darren Hart <dvhart@linux.intel.com>
GCC often introduces new warnings with lots of false positives -
breaking -Werror builds. WERROR=0 allows one to build perf without much
fuss - while still encouraging people to send patches to avoid the fuss
of having to type WERROR=0.
Bisecting back to commits that produce a (mostly harmless) warning on
some compilers is more difficult. With WERROR=0 one could bisect without
worrying about harmless warnings.
Cc: Ingo Molnar <mingo@elte.hu>
Link: http://lkml.kernel.org/r/eac06c7cc4920e5d4830417d466161fb26c7359c.1315514559.git.dvhart@linux.intel.com
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Makefile | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 3b8f7b8..e9d5c27 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -30,6 +30,8 @@ endif
# Define EXTRA_CFLAGS=-m64 or EXTRA_CFLAGS=-m32 as appropriate for cross-builds.
#
# Define NO_DWARF if you do not want debug-info analysis feature at all.
+#
+# Define WERROR=0 to disable treating any warnings as errors.
$(OUTPUT)PERF-VERSION-FILE: .FORCE-PERF-VERSION-FILE
@$(SHELL_PATH) util/PERF-VERSION-GEN $(OUTPUT)
@@ -63,6 +65,11 @@ ifeq ($(ARCH),x86_64)
endif
endif
+# Treat warnings as errors unless directed not to
+ifneq ($(WERROR),0)
+ CFLAGS_WERROR := -Werror
+endif
+
#
# Include saner warnings here, which can catch bugs:
#
@@ -95,7 +102,7 @@ ifndef PERF_DEBUG
CFLAGS_OPTIMIZE = -O6
endif
-CFLAGS = -fno-omit-frame-pointer -ggdb3 -Wall -Wextra -std=gnu99 -Werror $(CFLAGS_OPTIMIZE) -D_FORTIFY_SOURCE=2 $(EXTRA_WARNINGS) $(EXTRA_CFLAGS)
+CFLAGS = -fno-omit-frame-pointer -ggdb3 -Wall -Wextra -std=gnu99 $(CFLAGS_WERROR) $(CFLAGS_OPTIMIZE) -D_FORTIFY_SOURCE=2 $(EXTRA_WARNINGS) $(EXTRA_CFLAGS)
EXTLIBS = -lpthread -lrt -lelf -lm
ALL_CFLAGS = $(CFLAGS) -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
ALL_LDFLAGS = $(LDFLAGS)
--
1.6.2.5
next prev parent reply other threads:[~2011-09-23 20:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 20:26 [GIT PULL 00/12] perf tools fixes Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 01/12] perf probe: Fix regression of variable finder Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 02/12] perf symbols: Fix ppc64 SEGV in dso__load_sym with debuginfo files Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 03/12] perf symbols: /proc/kallsyms does not sort module symbols Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 04/12] perf symbols: Preserve symbol scope when parsing /proc/kallsyms Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 05/12] perf symbols: Add some heuristics for choosing the best duplicate symbol Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 06/12] perf record: Create events initially disabled and enable after init Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 07/12] perf symbols: Synthesize anonymous mmap events Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 08/12] perf sort: Fix symbol sort output by separating unresolved samples by type Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 09/12] perf tool: Fix endianness handling of u32 data in samples Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 10/12] perf symbols: Fix issue with binaries using 16-bytes buildids (v2) Arnaldo Carvalho de Melo
2011-09-23 20:26 ` [PATCH 11/12] perf top: Fix userspace sample addr map offset Arnaldo Carvalho de Melo
2011-09-23 20:26 ` Arnaldo Carvalho de Melo [this message]
2011-09-23 21:03 ` [GIT PULL 00/12] perf tools fixes Linus Torvalds
2011-09-23 21:05 ` Arnaldo Carvalho de Melo
2011-09-23 21:05 ` Linus Torvalds
2011-09-23 21:11 ` Arnaldo Carvalho de Melo
2011-09-23 21:25 ` Arnaldo Carvalho de Melo
2011-09-23 23:12 ` Linus Torvalds
2011-09-23 23:31 ` Arnaldo Carvalho de Melo
2011-09-23 23:46 ` Arnaldo Carvalho de Melo
2011-09-24 3:46 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316809586-28529-13-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=acme@redhat.com \
--cc=dvhart@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®