From: Steven Rostedt <rostedt@goodmis.org>
To: Greg Thelen <gthelen@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
bsingharora@gmail.com,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
PeterZijlstra <peterz@infradead.org>,
ChristophLameter <cl@linux.com>
Subject: Re: [PATCH] memcg: Fix race condition in memcg_check_events() with this_cpu usage
Date: Fri, 23 Sep 2011 22:41:32 -0400 [thread overview]
Message-ID: <1316832094.6387.11.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <CAHH2K0agLygD6cREazsTquCT=Whx97RxxhOneWpVF1cHwMwp3A@mail.gmail.com>
On Fri, 2011-09-23 at 19:39 -0700, Greg Thelen wrote:
> cc: updated Balbir Singh email address
>
> On Fri, Sep 23, 2011 at 7:34 PM, Greg Thelen <gthelen@google.com> wrote:
> > On Fri, Sep 23, 2011 at 5:54 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> >> From: Steven Rostedt <srostedt@redhat.com>
> >>
> >> The code in memcg_check_events() calls this_cpu_read() on
> >> different variables without disabling preemption, and can cause
> >> the calculations to be done from two different CPU variables.
> >>
> >> Disable preemption throughout the check to keep apples and oranges
> >> from becoming a mixed drink.
> >>
> >> [ Added this_cpu to __this_cpu conversion by Johannes ]
> >>
> >> Cc: Greg Thelen <gthelen@google.com>
> >> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> >> Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
>
> Correction:
> Cc: Balbir Singh <bsingharora@gmail.com>
Thanks, I was starting to hate that "return mail to sender" thing.
-- Steve
>
> >> Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
> >> Cc: Andrew Morton <akpm@linux-foundation.org>
> >> Cc: Thomas Gleixner <tglx@linutronix.de>
> >> Cc: Peter Zijlstra <peterz@infradead.org>
> >> Cc: Christoph Lameter <cl@linux.com>
> >> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> >> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> >> Link: http://lkml.kernel.org/r/20110919212641.015320989@goodmis.org
> >
> > Looks good to me. Thanks.
> >
> > Reviewed-by: Greg Thelen <gthelen@google.com>
> >
next prev parent reply other threads:[~2011-09-24 2:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-24 0:54 Steven Rostedt
2011-09-24 2:34 ` Greg Thelen
2011-09-24 2:39 ` Greg Thelen
2011-09-24 2:41 ` Steven Rostedt [this message]
2011-09-27 10:21 ` Balbir Singh
2011-09-27 16:16 ` Christoph Lameter
2011-09-26 0:43 ` KAMEZAWA Hiroyuki
2011-09-26 23:45 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316832094.6387.11.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=cl@linux.com \
--cc=gthelen@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®