From: Mark Einon <mark.einon@gmail.com>
To: gregkh@suse.de
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
o.hartmann@telovital.com, alan@linux.intel.com,
Mark Einon <mark.einon@gmail.com>
Subject: [PATCH 6/6] staging: et131x: Bugfix - driver doesn't autoreneg after cable unplug/plug events
Date: Sun, 25 Sep 2011 19:17:57 +0100 [thread overview]
Message-ID: <1316974677-17108-6-git-send-email-mark.einon@gmail.com> (raw)
In-Reply-To: <1316974677-17108-1-git-send-email-mark.einon@gmail.com>
This driver has a long standing bug where removing and inserting the ethernet cable results in no packets being
trnasmitted / received and hence no autonegotiation occurring.
Fixed by resetting the rx/tx engines and queue on detecting a cable being removed.
Signed-off-by: Mark Einon <mark.einon@gmail.com>
---
drivers/staging/et131x/et131x_initpci.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/et131x/et131x_initpci.c b/drivers/staging/et131x/et131x_initpci.c
index 618f844..e9daa73 100644
--- a/drivers/staging/et131x/et131x_initpci.c
+++ b/drivers/staging/et131x/et131x_initpci.c
@@ -544,6 +544,10 @@ static void et131x_adjust_link(struct net_device *netdev)
/* Setup ET1310 as per the documentation */
et131x_adapter_setup(adapter);
+
+ /* perform reset of tx/rx */
+ et131x_disable_txrx(netdev);
+ et131x_enable_txrx(netdev);
}
adapter->link = phydev->link;
--
1.7.6
prev parent reply other threads:[~2011-09-25 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-25 18:17 [PATCH 1/6] staging: et131x: support register dump in ethtool ops Mark Einon
2011-09-25 18:17 ` [PATCH 2/6] staging: et131x: Add link status to adapter struct Mark Einon
2011-09-25 18:17 ` [PATCH 3/6] staging: et131x: Remove et131x_check_mii() and move functionality into et131x_adjust_link() Mark Einon
2011-09-25 18:17 ` [PATCH 4/6] staging: et131x: Create et131x_[dis|en]able_txrx() calls Mark Einon
2011-09-25 18:17 ` [PATCH 5/6] staging: et131x: Remove header declaration of et131x_check_mii() Mark Einon
2011-09-25 18:17 ` Mark Einon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316974677-17108-6-git-send-email-mark.einon@gmail.com \
--to=mark.einon@gmail.com \
--cc=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=o.hartmann@telovital.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®