From: Steven Whitehouse <swhiteho@redhat.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, cluster-devel@redhat.com
Subject: Re: [PATCH] gfs2/inode.c: local functions should be static
Date: Mon, 26 Sep 2011 09:27:38 +0100 [thread overview]
Message-ID: <1317025658.2744.0.camel@menhir> (raw)
In-Reply-To: <201109231551.32939.hartleys@visionengravers.com>
Hi,
On Fri, 2011-09-23 at 15:51 -0700, H Hartley Sweeten wrote:
> Quiets the sparse noise:
>
> warning: symbol 'gfs2_initxattrs' was not declared. Should it be static?
>
Where did you find this function? It is not in the upstream gfs2 code...
Steve.
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Steven Whitehouse <swhiteho@redhat.com>
>
> ---
>
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 5431de9..5f2b157 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -624,7 +624,7 @@ fail:
> return error;
> }
>
> -int gfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> +static int gfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> void *fs_info)
> {
> const struct xattr *xattr;
next prev parent reply other threads:[~2011-09-26 8:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 22:51 H Hartley Sweeten
2011-09-26 8:27 ` Steven Whitehouse [this message]
2011-09-26 16:54 ` H Hartley Sweeten
2011-09-26 18:37 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317025658.2744.0.camel@menhir \
--to=swhiteho@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®