From: Peter Zijlstra <peterz@infradead.org>
To: Bob Liu <lliubbo@gmail.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, joe@perches.com,
tglx@linutronix.de
Subject: Re: [PATCH] spinlock: rm duplicated preempt en/disable for bottom half
Date: Tue, 27 Sep 2011 11:13:56 +0200 [thread overview]
Message-ID: <1317114837.15383.1.camel@twins> (raw)
In-Reply-To: <1317110185-9219-1-git-send-email-lliubbo@gmail.com>
On Tue, 2011-09-27 at 15:56 +0800, Bob Liu wrote:
> local_bh_en/disable() has already deal with en/disable preempt, so rm the
> dumplicated one from spinlock_api_up/smp.h head file.
I bet you haven't tried booting this.. you just broke stuff like:
spin_lock_bh(&foo);
/* do crap */
spin_unlock(&foo);
/* do some other crap */
local_bh_enable();
And yes that does happen.
next prev parent reply other threads:[~2011-09-27 9:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 7:56 Bob Liu
2011-09-27 9:13 ` Peter Zijlstra [this message]
2011-09-27 9:40 ` Bob Liu
2011-09-27 9:57 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317114837.15383.1.camel@twins \
--to=peterz@infradead.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lliubbo@gmail.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®