From: Joe Perches <joe@perches.com>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: jack@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] udf: enable error print in udf_read_tagged().
Date: Tue, 27 Sep 2011 09:18:30 -0700 [thread overview]
Message-ID: <1317140310.16786.2.camel@Joe-Laptop> (raw)
In-Reply-To: <1317138382-1966-1-git-send-email-linkinjeon@gmail.com>
On Wed, 2011-09-28 at 00:46 +0900, Namjae Jeon wrote:
> While reading metadata, if a problem occurs, Print out only one of the five case.(It also does not show a checksum properly.)
[]
> diff --git a/fs/udf/misc.c b/fs/udf/misc.c
[]
> @@ -211,7 +212,7 @@ struct buffer_head *udf_read_tagged(struct super_block *sb, uint32_t block,
>
> bh = udf_tread(sb, block);
> if (!bh) {
> - udf_debug("block=%d, location=%d: read failed\n",
> + printk(KERN_ERR "block=%d, location=%d: read failed\n",
The other printk in this module uses a "udf: " prefix.
I suggest that
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
is added before any include and these
conversions use pr_err() instead.
next prev parent reply other threads:[~2011-09-27 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 15:46 Namjae Jeon
2011-09-27 16:18 ` Joe Perches [this message]
2011-09-28 1:08 ` NamJae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317140310.16786.2.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=jack@suse.cz \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®