From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752589Ab1I1EKz (ORCPT ); Wed, 28 Sep 2011 00:10:55 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:41857 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738Ab1I1EKy (ORCPT ); Wed, 28 Sep 2011 00:10:54 -0400 Subject: Re: [PATCH] block: Free queue resources at blk_release_queue() From: James Bottomley To: Linus Torvalds Cc: Jens Axboe , Hannes Reinecke , James Bottomley , "linux-scsi@vger.kernel.org" , Linux Kernel In-Reply-To: References: <201109221318.p8MDIXPP020015@pentland.suse.de> <20110928004722.GA27421@kernel.dk> <4E82751C.9050908@kernel.dk> Content-Type: text/plain; charset="UTF-8" Date: Tue, 27 Sep 2011 23:10:38 -0500 Message-ID: <1317183038.17578.9.camel@dabdike.hansenpartnership.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2011-09-27 at 18:59 -0700, Linus Torvalds wrote: > On Tue, Sep 27, 2011 at 6:15 PM, Jens Axboe wrote: > >> > >> But if you forward the actual patch to me (the one I see on lkml seems > >> to be broken and doesn't compile cleanly because it's assiging a > >> structure to a pointer), I'll try it out anyway. > > > > Thanks, that would be great. It's inlined below. > > Well, I did several USB eject events, and nothing bad happened. > > But as mentioned, I don't think that means much. Have you tried this > with slub debugging and poisoning? It might be worth some extra > testing that way. I've been testing a simpler version: http://marc.info/?l=linux-kernel&m=131300594629839 For a long time now with great success. The only difference is the locking cleanup, but SCSI doesn't need that since it doesn't supply its own lock, so I've been voting for this as the final fix for a while now. James