From: Mike Galbraith <efault@gmx.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Subject: Re: x86: interrupt routing question
Date: Wed, 28 Sep 2011 09:28:52 +0200 [thread overview]
Message-ID: <1317194932.6506.94.camel@marge.simson.net> (raw)
In-Reply-To: <1310455620.4844.29.camel@marge.simson.net>
For the next sod who gets curious about irq routing behavior difference,
and tries to ask google.
On Tue, 2011-07-12 at 09:27 +0200, Mike Galbraith wrote:
> Greetings,
>
> I have an x3550 M3 box which shows different behavior than my Q6600
> desktop box. The below is the rt kernel, but it doesn't matter which
> kernel I boot, all interrupts are on CPU0 unless I move them. On Q6600
> box, IRQs magically appear on every cpu in the affinity mask. Change
> the eth0 mask while flood pinging, numbers start/stop changing on the
> fly.
>
> On x3550 M3, setting eg IRQ 63's mask to '0xe' will move irq to CPU2,
> but nothing that I have found will make the thing behave the same as
> trusty old Q6600 box, which seems strange. Is this some kind of BIOS
> thingie, or is every kernel busted on this hardware? Busted kernel
> seems highly doubtful.
The difference is that Q6600 desktop box uses flat routing, and x3550 M3
uses physical flat. What the heck does that mean you (didn't) ask?
Dunno, that's a "RTFM for all the gory technical details" thing, but if
you rummage around in x86 source, you'll end up here..
arch/kernel/x86/apic/io_apic.c::setup_ioapic_irq()
if (assign_irq_vector(irq, cfg, apic->target_cpus()))
return;
dest = apic->cpu_mask_to_apicid_and(cfg->domain, apic->target_cpus());
apic_printk(APIC_VERBOSE,KERN_DEBUG
"IOAPIC[%d]: Set routing entry (%d-%d -> 0x%x -> "
"IRQ %d Mode:%i Active:%i Dest:%d)\n",
apic_id, mpc_ioapic_id(apic_id), pin, cfg->vector,
irq, trigger, polarity, dest);
..and see that in physical flat mode, assign_irq_vector() scribbles only
one bit to cfg->domain.
arch/kernel/x86/apic/io_apic.c:__assign_irq_vector()
for_each_cpu_and(cpu, mask, cpu_online_mask) {
int new_cpu;
int vector, offset;
apic->vector_allocation_domain(cpu, tmp_mask);
...
cpumask_copy(cfg->domain, tmp_mask);
err = 0;
break;
}
apic.vector_allocation_domain for physical flat is..
arch/x86/kernel/apic/apic_flat_64.c::
static void physflat_vector_allocation_domain(int cpu, struct cpumask *retmask)
{
cpumask_clear(retmask);
cpumask_set_cpu(cpu, retmask);
}
..whereas for flat it's..
static void flat_vector_allocation_domain(int cpu, struct cpumask *retmask)
{
...
cpumask_clear(retmask);
cpumask_bits(retmask)[0] = APIC_ALL_CPUS;
}
So, while __assign_irq_vector() is called with a mask of all CPUs for
both boxen, apic->vector_allocation_domain() ensures the mask finally
written to cfg->domain has only one CPU bit set in physical flat mode,
and all CPU bits set in flat mode.
-Mike
P.S. if you try that RTFM thing, strap a pillow to your forehead first
next prev parent reply other threads:[~2011-09-28 7:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 7:27 Mike Galbraith
2011-09-28 7:28 ` Mike Galbraith [this message]
2011-09-28 15:26 ` Bjorn Helgaas
2011-09-28 17:33 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317194932.6506.94.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome