From: Matthew Garrett <mjg@redhat.com>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, arjan@infradead.org,
Matthew Garrett <mjg@redhat.com>
Subject: [PATCH] hrtimers: Special-case zero length sleeps
Date: Thu, 29 Sep 2011 10:59:32 -0400 [thread overview]
Message-ID: <1317308372-6810-1-git-send-email-mjg@redhat.com> (raw)
sleep(0) is a common construct used by applications that want to trigger
the scheduler. sched_yield() might make more sense, but only appeared in
POSIX.1-2001 and so plenty of example code still uses the sleep(0) form.
This wouldn't normally be a problem, but it means that event-driven
applications that are merely trying to avoid starving other processes may
actually end up sleeping due to having large timer_slack values. Special-
casing this seems reasonable.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
kernel/hrtimer.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c
index a9205e3..0bb70a7 100644
--- a/kernel/hrtimer.c
+++ b/kernel/hrtimer.c
@@ -1566,6 +1566,14 @@ long hrtimer_nanosleep(struct timespec *rqtp, struct timespec __user *rmtp,
if (rt_task(current))
slack = 0;
+ /*
+ * Applications will often sleep(0) to indicate that they wish to
+ * be scheduled. Special case that to avoid actually putting them
+ * to sleep for the duration of the slack.
+ */
+ if (rqtp->tv_sec == 0 && rqtp->tv_nsec == 0)
+ slack = 0;
+
hrtimer_init_on_stack(&t.timer, clockid, mode);
hrtimer_set_expires_range_ns(&t.timer, timespec_to_ktime(*rqtp), slack);
if (do_nanosleep(&t, mode))
--
1.7.6.4
next reply other threads:[~2011-09-29 14:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 14:59 Matthew Garrett [this message]
2012-02-15 14:40 ` Thomas Gleixner
2012-02-15 14:52 ` Matthew Garrett
2012-02-15 20:14 ` Thomas Gleixner
2012-02-15 20:22 ` Matthew Garrett
2012-02-15 20:30 ` Thomas Gleixner
2012-02-15 20:38 ` Matthew Garrett
2012-02-15 20:40 ` Peter Zijlstra
2012-02-15 20:43 ` Matthew Garrett
2012-02-15 20:46 ` Thomas Gleixner
2012-02-15 20:47 ` Matthew Garrett
2012-02-16 14:27 ` Matthew Garrett
2012-02-16 14:31 ` Alan Cox
2012-02-16 14:51 ` Peter Zijlstra
2012-02-16 15:01 ` Matthew Garrett
2012-02-16 19:09 ` Thomas Gleixner
2012-02-15 14:54 ` Peter Zijlstra
2012-02-15 14:58 ` Matthew Garrett
2012-02-15 20:22 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317308372-6810-1-git-send-email-mjg@redhat.com \
--to=mjg@redhat.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®