mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vasily Averin <vvs@parallels.com>
To: <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, Vasily Averin <vvs@sw.ru>
Subject: [PATCH] watchdog: move watchdog_*_all_cpus under CONFIG_SYSCTL
Date: Fri, 30 Sep 2011 15:12:54 +0400	[thread overview]
Message-ID: <1317381174-19596-1-git-send-email-vvs@parallels.com> (raw)

From: Vasily Averin <vvs@sw.ru>

fixed compilation warnings in case of disabled CONFIG_SYSCTL
kernel/watchdog.c:483:13: warning: ‘watchdog_enable_all_cpus’ defined but not used
kernel/watchdog.c:500:13: warning: ‘watchdog_disable_all_cpus’ defined but not used

these functions are are static and are used only in sysctl handler,
so move them inside #ifdef CONFIG_SYSCTL too

Signed-off-by: Vasily Averin <vvs@sw.ru>
---
 kernel/watchdog.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 36491cd..13644ee 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -480,6 +480,8 @@ static void watchdog_disable(int cpu)
 	}
 }
 
+/* sysctl functions */
+#ifdef CONFIG_SYSCTL
 static void watchdog_enable_all_cpus(void)
 {
 	int cpu;
@@ -508,9 +510,6 @@ static void watchdog_disable_all_cpus(void)
 	watchdog_enabled = 0;
 }
 
-
-/* sysctl functions */
-#ifdef CONFIG_SYSCTL
 /*
  * proc handler for /proc/sys/kernel/nmi_watchdog,watchdog_thresh
  */
-- 
1.7.4.1


                 reply	other threads:[~2011-09-30 11:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317381174-19596-1-git-send-email-vvs@parallels.com \
    --to=vvs@parallels.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vvs@sw.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®