From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755235Ab1JCFjd (ORCPT ); Mon, 3 Oct 2011 01:39:33 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:45283 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755041Ab1JCFj1 (ORCPT ); Mon, 3 Oct 2011 01:39:27 -0400 Message-ID: <1317620365.1804.7.camel@Joe-Laptop> Subject: Re: [PATCH 1/2] udf : enable error print in udf_read_tagged(). From: Joe Perches To: Namjae Jeon Cc: jack@suse.cz, linux-kernel@vger.kernel.org Date: Sun, 02 Oct 2011 22:39:25 -0700 In-Reply-To: <1317617737-22035-1-git-send-email-linkinjeon@gmail.com> References: <1317617737-22035-1-git-send-email-linkinjeon@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.0- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2011-10-03 at 13:55 +0900, Namjae Jeon wrote: > While reading metadata, if a problem occurs, > Print out only one of the five case.(It also does not show a checksum properly.) > Because currently it have been disable by undef udf_debug. > If there is a problem with scratched disc or loader, the user needs to know which error happened. > And I use pr_fmt instead of printk by joe's suggestion. I try to modify totally it to pr_fmt also. [] > diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h [] > @@ -21,7 +23,7 @@ > #ifdef UDFFS_DEBUG > #define udf_debug(f, a...) \ > do { \ > - printk(KERN_DEBUG "UDF-fs DEBUG %s:%d:%s: ", \ > + pr_debug("DEBUG %s:%d:%s: ", \ > __FILE__, __LINE__, __func__); \ > printk(f, ##a); \ This isn't the same. You should probably just use #define udf_debug(fmt, ...) \ pr_debug("DEBUG %s:%d:%s: " fmt, \ __FILE__, __LINE__, __func__, __VA_ARGS__) or maybe let dynamic_debug add __FILE__, __LINE__ and __func__ via the appropriate controls, so this might be appropriate. #define udf_debug(fmt, ...) \ pr_debug("DEBUG " fmt, __VA_ARGS__)