mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
To: Jean Delvare <khali@linux-fr.org>,
	Ben Dooks <ben-linux@fluff.org>,
	Wolfram Sang <w.sang@pengutronix.de>, Qi Wang <qi.wang@intel.com>,
	Linus Walleij <linus.walleij@stericsson.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: yong.y.wang@intel.com, joel.clark@intel.com,
	kok.howg.ewe@intel.com, toshiharu-linux@dsn.lapis-semi.com,
	Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
Subject: [PATCH 4/7 v2] i2c-eg20t: add stop sequence in case wait-event timeout occurs
Date: Wed,  5 Oct 2011 13:17:41 +0900	[thread overview]
Message-ID: <1317788264-13118-4-git-send-email-tomoya-linux@dsn.lapis-semi.com> (raw)
In-Reply-To: <1317788264-13118-1-git-send-email-tomoya-linux@dsn.lapis-semi.com>

add stop sequence in case wait-event timeout in write processing.
(read processing already had it)

Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
---
 drivers/i2c/busses/i2c-eg20t.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
index 29911c5..ecabf5e 100644
--- a/drivers/i2c/busses/i2c-eg20t.c
+++ b/drivers/i2c/busses/i2c-eg20t.c
@@ -430,6 +430,7 @@ static s32 pch_i2c_writebytes(struct i2c_adapter *i2c_adap,
 		pch_clrbit(adap->pch_base_address, PCH_I2CSR, I2CMIF_BIT);
 		return -EAGAIN;
 	} else { /* wait-event timeout */
+		pch_i2c_stop(adap);
 		return -ETIME;
 	}
 
@@ -450,6 +451,7 @@ static s32 pch_i2c_writebytes(struct i2c_adapter *i2c_adap,
 			pch_clrbit(adap->pch_base_address, PCH_I2CSR,
 				   I2CMIF_BIT);
 		} else { /* wait-event timeout */
+			pch_i2c_stop(adap);
 			return -ETIME;
 		}
 	}
-- 
1.7.6.4


  parent reply	other threads:[~2011-10-05  4:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-05  4:17 [PATCH 1/7 v2] i2c-eg20t: Modify returned value s32 to long Tomoya MORINAGA
2011-10-05  4:17 ` [PATCH 2/7 v2] i2c-eg20t: delete 10bit access processing Tomoya MORINAGA
2011-10-05 17:29   ` Jeffrey (Sheng-Hui) Chu
2011-10-06  6:42     ` Tomoya MORINAGA
2011-10-05  4:17 ` [PATCH 3/7 v2] i2c-eg20t: Separate error processing Tomoya MORINAGA
2011-10-05  4:17 ` Tomoya MORINAGA [this message]
2011-10-05  4:17 ` [PATCH 5/7 v2] i2c-eg20t: Fix flag setting issue Tomoya MORINAGA
2011-10-05  4:17 ` [PATCH 6/7 v2] i2c-eg20t: Add initialize processing in case i2c-error occurs Tomoya MORINAGA
2011-10-05  4:17 ` [PATCH 7/7 v2] i2c-eg20t: Fix bus-idle waiting issue Tomoya MORINAGA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317788264-13118-4-git-send-email-tomoya-linux@dsn.lapis-semi.com \
    --to=tomoya-linux@dsn.lapis-semi.com \
    --cc=ben-linux@fluff.org \
    --cc=joel.clark@intel.com \
    --cc=khali@linux-fr.org \
    --cc=kok.howg.ewe@intel.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qi.wang@intel.com \
    --cc=toshiharu-linux@dsn.lapis-semi.com \
    --cc=w.sang@pengutronix.de \
    --cc=yong.y.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®