From: Joe Perches <joe@perches.com>
To: Will Drewry <wad@chromium.org>
Cc: Rabin Vincent <rabin@rab.in>,
axboe@kernel.dk, linux-kernel@vger.kernel.org
Subject: [alternate PATCH] block: fix UUID string buffer length
Date: Wed, 05 Oct 2011 09:48:30 -0700 [thread overview]
Message-ID: <1317833310.1782.33.camel@Joe-Laptop> (raw)
In-Reply-To: <CABqD9hYw3qcMpcjyEtvstYD-WRB=QkVPS5S0MBbah=veZv9E6A@mail.gmail.com>
The UUID string buffer is several bytes shorter than what is actually
required. Fix it and remove the used once inline part_unpack_uuid,
use snprintf and printf extension %pU directly.
Based-on-a-patch-by: Rabin Vincent <rabin@rab.in>
cc: Will Drewry <wad@chromium.org>
Signed-off-by: Joe Perches <joe@perches.com>
---
block/genhd.c | 8 +++++---
include/linux/genhd.h | 6 ------
2 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/block/genhd.c b/block/genhd.c
index e2f6790..427c955 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -735,7 +735,7 @@ void __init printk_all_partitions(void)
struct hd_struct *part;
char name_buf[BDEVNAME_SIZE];
char devt_buf[BDEVT_SIZE];
- u8 uuid[PARTITION_META_INFO_UUIDLTH * 2 + 1];
+ char uuid[sizeof("12345678-1234-1234-1234-123456789012")];
/*
* Don't show empty devices or things that have been
@@ -754,9 +754,11 @@ void __init printk_all_partitions(void)
while ((part = disk_part_iter_next(&piter))) {
bool is_part0 = part == &disk->part0;
- uuid[0] = 0;
if (part->info)
- part_unpack_uuid(part->info->uuid, uuid);
+ snprintf(uuid, sizeof(uuid),
+ "%pU", part->info->uuid);
+ else
+ uuid[0] = '\0';
printk("%s%s %10llu %s %s", is_part0 ? "" : " ",
bdevt_str(part_devt(part), devt_buf),
diff --git a/include/linux/genhd.h b/include/linux/genhd.h
index 02fa469..28bd275 100644
--- a/include/linux/genhd.h
+++ b/include/linux/genhd.h
@@ -221,12 +221,6 @@ static inline void part_pack_uuid(const u8 *uuid_str, u8 *to)
}
}
-static inline char *part_unpack_uuid(const u8 *uuid, char *out)
-{
- sprintf(out, "%pU", uuid);
- return out;
-}
-
static inline int disk_max_parts(struct gendisk *disk)
{
if (disk->flags & GENHD_FL_EXT_DEVT)
next prev parent reply other threads:[~2011-10-05 16:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 9:52 [PATCH] " Rabin Vincent
2011-10-05 14:41 ` Will Drewry
2011-10-05 16:48 ` Joe Perches [this message]
2011-10-05 18:11 ` [alternate PATCH] " Vivek Goyal
2011-10-05 18:18 ` Joe Perches
2011-10-05 18:24 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317833310.1782.33.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=rabin@rab.in \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®