mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Davis <alex14641@yahoo.com>
To: Keith Packard <keithp@keithp.com>,
	"terraluna977@gmail.com" <terraluna977@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Matthew Garrett <mjg@redhat.com>
Subject: Re:  Regression: i915 blank issue on kernel 3.1.0-rc3
Date: Wed, 5 Oct 2011 12:59:40 -0700 (PDT)	[thread overview]
Message-ID: <1317844780.69103.YahooMailNeo@web130122.mail.mud.yahoo.com> (raw)
In-Reply-To: <yun1uuslfhg.fsf@aiko.keithp.com>

.From: Keith Packard <keithp@keithp.com>
>> The following patch fixed my backlight issues:
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
>> index a9e0c7b..6f56676 100644
>> --- a/drivers/gpu/drm/i915/intel_panel.c
>> +++ b/drivers/gpu/drm/i915/intel_panel.c
>> @@ -262,8 +262,6 @@ void intel_panel_disable_backlight(struct drm_device *dev)
>>          dev_priv->backlight_level = intel_panel_get_backlight(dev);
>>          dev_priv->backlight_enabled = false;
>>      }
>> -
>> -    intel_panel_set_backlight(dev, 0);
>>  }
>>  
>>  void intel_panel_enable_backlight(struct drm_device *dev)
>> 
>> I've been using it since yesterday morning with no issues.
>
>Matthew -- if we cannot resolve this backlight issue, we're going to
>need to disable the new backlight code for 3.1. Do you want to try and
>fix it? Or should we bail for now?

By 'disable', do you mean revert? If so, I would the like chance to submit a patch that adds a boot parameter 
for the driver to disable the backlight by default, e.g: i915_disable_bl. Once the issues are sorted, the
parameter could be removed.

  reply	other threads:[~2011-10-05 19:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-25 13:37 Alex Davis
2011-10-03 21:10 ` Alex Davis
2011-10-04 19:32   ` Keith Packard
2011-10-05 19:59     ` Alex Davis [this message]
2011-10-05 20:16       ` Keith Packard
2011-10-05 21:20         ` Alex Davis
2011-10-05 21:42           ` Keith Packard
2011-10-05 21:59             ` Alex Davis
2011-10-06 22:00             ` Alex Davis
  -- strict thread matches above, loose matches on Subject: below --
2011-09-25 21:13 Alex Davis
2011-09-21 23:02 i915 blank issue on kernel 3.1.0 Woody Suwalski
2011-09-22  4:35 ` Keith Packard
2011-09-25 13:15   ` Regression: i915 blank issue on kernel 3.1.0-rc3 Woody Suwalski
2011-09-25 14:23   ` Woody Suwalski
2011-09-25 20:27     ` Keith Packard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317844780.69103.YahooMailNeo@web130122.mail.mud.yahoo.com \
    --to=alex14641@yahoo.com \
    --cc=keithp@keithp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=terraluna977@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome