From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753413Ab1JGPR1 (ORCPT ); Fri, 7 Oct 2011 11:17:27 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48475 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753217Ab1JGPR0 (ORCPT ); Fri, 7 Oct 2011 11:17:26 -0400 From: Mel Gorman To: Rik van Riel , Johannes Weiner , akpm@linux-foundation.org Cc: Josh Boyer , aarcange@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] mm: vmscan: Limit direct reclaim for higher order allocations Date: Fri, 7 Oct 2011 16:17:22 +0100 Message-Id: <1318000643-27996-2-git-send-email-mgorman@suse.de> X-Mailer: git-send-email 1.7.3.4 In-Reply-To: <1318000643-27996-1-git-send-email-mgorman@suse.de> References: <1318000643-27996-1-git-send-email-mgorman@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rik van Riel When suffering from memory fragmentation due to unfreeable pages, THP page faults will repeatedly try to compact memory. Due to the unfreeable pages, compaction fails. Needless to say, at that point page reclaim also fails to create free contiguous 2MB areas. However, that doesn't stop the current code from trying, over and over again, and freeing a minimum of 4MB (2UL << sc->order pages) at every single invocation. This resulted in my 12GB system having 2-3GB free memory, a corresponding amount of used swap and very sluggish response times. This can be avoided by having the direct reclaim code not reclaim from zones that already have plenty of free memory available for compaction. If compaction still fails due to unmovable memory, doing additional reclaim will only hurt the system, not help. Signed-off-by: Rik van Riel Signed-off-by: Mel Gorman --- mm/vmscan.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index b55699c..3817fa9 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2066,6 +2066,16 @@ static void shrink_zones(int priority, struct zonelist *zonelist, continue; if (zone->all_unreclaimable && priority != DEF_PRIORITY) continue; /* Let kswapd poll it */ + if (COMPACTION_BUILD) { + /* + * If we already have plenty of memory free + * for compaction, don't free any more. + */ + if (sc->order > PAGE_ALLOC_COSTLY_ORDER && + (compaction_suitable(zone, sc->order) || + compaction_deferred(zone))) + continue; + } /* * This steals pages from memory cgroups over softlimit * and returns the number of reclaimed pages and -- 1.7.3.4