From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750920Ab1JIE4b (ORCPT ); Sun, 9 Oct 2011 00:56:31 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:38902 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750702Ab1JIE43 (ORCPT ); Sun, 9 Oct 2011 00:56:29 -0400 Message-ID: <1318136188.1844.56.camel@Joe-Laptop> Subject: Re: [PATCH 1/2 v3] udf : enable error print in udf_read_tagged(). From: Joe Perches To: NamJae Jeon Cc: Jan Kara , linux-kernel@vger.kernel.org Date: Sat, 08 Oct 2011 21:56:28 -0700 In-Reply-To: References: <1317650037-4648-1-git-send-email-linkinjeon@gmail.com> <20111005220813.GK23467@quack.suse.cz> <1317853198.3095.19.camel@Joe-Laptop> <20111006214159.GK31367@quack.suse.cz> <1318130976.1844.48.camel@Joe-Laptop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.0- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2011-10-09 at 13:44 +0900, NamJae Jeon wrote: > 2011/10/9 Joe Perches : > > Not a good patch I think. > > You've broken format strings when they should be coalesced > > and the alignment looks odd. > Would you explain more ? I didn't understand your meaning yet. Format strings are allowed to exceed 80 columns. Arguments should be aligned to the open parenthesis For example: pr_err("some really long format string longer than " "80 columns and not broken into pieces, Count: %d\n", count); is better as: pr_err("some really long format string longer than 80 columns and not broken into pieces, Count: %d\n", count); Coalesced format strings makes dmesg output easier to grep. count is not indented by 2 tabs, but 1 tab and 7 spaces. There's no hard and fast rule on the indentation. The patch I sent coalesced all format strings and used that alignment style.